-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a language switcher in README.md file. #1610
base: main
Are you sure you want to change the base?
Conversation
And create a README_zh_CN.md file that is a Cinnese translation copy of README.md. Signed-off-by: shawn_shaw <cola_ocean@foxmail.com>
Signed-off-by: shawn_shaw <cola_ocean@foxmail.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io> Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io> Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Signed-off-by: shawn_shaw <cola_ocean@foxmail.com>
@Shawn-Shaw-x Thank you for the first round of the translation. Making a start is always the hardest job. Thanks for doing this heavy-lifting job. I haven't finished all the reviews yet. A few suggestions so far:
please take a look at the suggestions so far and let me know if you have any questions. |
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io> Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io> Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io> Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Signed-off-by: shawn_shaw <cola_ocean@foxmail.com>
Signed-off-by: shawn_shaw <cola_ocean@foxmail.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io> Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io> Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io> Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io> Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io> Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io> Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io> Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io> Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io> Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io> Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io> Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io> Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io> Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io> Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io> Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io> Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io> Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io> Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io> Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io> Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io> Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
proof reading
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Shawn-Shaw-x and @Chengxuan for the reviews!
And create a README_zh_CN.md file that is a Cinnese translation copy of README.md.
Proposed changes
Please include a summary of the changes here and why we need those changes. And also let us know which issue is fixed.
Fixes # <issue_number_here>
Types of changes
Please make sure to follow these points
Screenshots (If Applicable)
Other Information
Raise PR again. Make DCO tool happy. Please check! Thank you! @EnriqueL8 @Chengxuan @jimthematrix