Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update workflows for ubuntu #105

Merged
merged 28 commits into from
Nov 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
8945986
ci: update workflows for ubuntu
goncalo-frade-iohk Nov 2, 2023
42c4995
fix: add prints to debug CI errors
cristianIOHK Nov 3, 2023
b410c33
fix: add prints to debug CI errors
cristianIOHK Nov 3, 2023
eb39111
fix: add prints to debug CI errors
cristianIOHK Nov 3, 2023
8782ad3
fix: add prints to debug CI errors
cristianIOHK Nov 3, 2023
ed0bb0c
fix: add prints to debug CI errors
cristianIOHK Nov 3, 2023
197b1fa
add unit test to verify the failing seed
cristianIOHK Nov 6, 2023
8d742a6
replace with failing seed
cristianIOHK Nov 6, 2023
6f78662
try catch and logs
cristianIOHK Nov 6, 2023
d4183a7
Further debugging
cristianIOHK Nov 6, 2023
221b6f9
Further debugging
cristianIOHK Nov 6, 2023
d122ef4
Further debugging
cristianIOHK Nov 6, 2023
8f2aa0d
Further debugging
cristianIOHK Nov 6, 2023
7d2b363
Update .github/workflows/e2e-tests.yml
cristianIOHK Nov 6, 2023
89f0a83
Further debugging
cristianIOHK Nov 6, 2023
75759ac
Further debugging
cristianIOHK Nov 6, 2023
f22197a
Further debugging
cristianIOHK Nov 6, 2023
bf868ce
fix: stackoverflow exception thrown
cristianIOHK Nov 6, 2023
b1d6286
fix: required changes to use apollo 1.0.3
cristianIOHK Nov 6, 2023
996add0
fix: use latest apollo buid to fix stackoverflow
cristianIOHK Nov 7, 2023
895ab02
fix: exclude apollo dependency from didpeer
cristianIOHK Nov 7, 2023
14b6c0a
fix: update to latest apollo
cristianIOHK Nov 7, 2023
11732b0
fix: use latest published apollo version 1.0.7
cristianIOHK Nov 8, 2023
be39297
fix: add stack trace to the build task + test.
elribonazo Nov 8, 2023
e522ea8
Update .github/workflows/pull-request.yml
cristianIOHK Nov 8, 2023
2d71976
fix: increase apollo and rollback to ubuntu.
elribonazo Nov 8, 2023
f76ab55
Merge branch 'main' into feature/ci-update-workflows
cristianIOHK Nov 8, 2023
100483e
fix: change e2e tests to run on ubuntu
cristianIOHK Nov 9, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/e2e-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ env:
jobs:
run-e2e-tests:
name: "Run"
runs-on: macos-latest
runs-on: ubuntu-latest
cristianIOHK marked this conversation as resolved.
Show resolved Hide resolved

steps:
- name: Mask apikey
Expand Down
23 changes: 6 additions & 17 deletions .github/workflows/pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,37 +24,26 @@ on:
jobs:

build:
runs-on: macos-latest
runs-on: ubuntu-latest
cristianIOHK marked this conversation as resolved.
Show resolved Hide resolved
steps:
- name: Checkout the repo
uses: actions/checkout@v3

- name: Validate Gradle Wrapper
uses: gradle/wrapper-validation-action@v1

- name: Cache gradle
uses: actions/cache@v3
with:
path: |
~/.gradle/caches
~/.gradle/wrapper
~/.konan
key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*') }}
restore-keys: |
${{ runner.os }}-gradle-

- name: Install Java ${{ env.JAVA_VERSION }}
uses: actions/setup-java@v3
with:
java-version: ${{ env.JAVA_VERSION }}
distribution: "adopt"
distribution: "zulu"

- name: Gradle Build Action
uses: gradle/gradle-build-action@v2

- name: Runner
run: echo ${{ runner.os }}

- name: Build for JS, Android, JVM
run: |
./gradlew build test koverXmlReport koverHtmlReport
./gradlew build test koverXmlReport koverHtmlReport --stacktrace

- name: Coverage Report
uses: mi-kas/kover-report@v1
Expand Down
10 changes: 4 additions & 6 deletions atala-prism-sdk/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,11 @@ kotlin {
implementation("io.ktor:ktor-serialization-kotlinx-json:2.3.4")
implementation("io.ktor:ktor-client-logging:2.3.4")

implementation("io.iohk.atala.prism.didcomm:didpeer:$didpeerVersion")
implementation("io.iohk.atala.prism.didcomm:didpeer:$didpeerVersion") {
exclude("io.iohk.atala.prism.apollo")
}

implementation("io.iohk.atala.prism.apollo:base-asymmetric-encryption:$apolloVersion")
implementation("io.iohk.atala.prism.apollo:base64:$apolloVersion")
implementation("io.iohk.atala.prism.apollo:hashing:$apolloVersion")
implementation("io.iohk.atala.prism.apollo:uuid:$apolloVersion")
implementation("io.iohk.atala.prism.apollo:multibase:$apolloVersion")
implementation("io.iohk.atala.prism.apollo:apollo:$apolloVersion")

// implementation("com.nimbusds:nimbus-jose-jwt:9.31") // We are going to use the `nimbus-jose-jwt` that resides in `didcomm` lib

Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package io.iohk.atala.prism.walletsdk.apollo

import io.iohk.atala.prism.apollo.derivation.HDKey
import io.iohk.atala.prism.apollo.derivation.Mnemonic
import io.iohk.atala.prism.apollo.derivation.MnemonicLengthException
import io.iohk.atala.prism.apollo.utils.Mnemonic
import io.iohk.atala.prism.walletsdk.apollo.helpers.BytesOps
import io.iohk.atala.prism.walletsdk.apollo.utils.Ed25519KeyPair
import io.iohk.atala.prism.walletsdk.apollo.utils.Ed25519PrivateKey
Expand Down Expand Up @@ -34,7 +34,7 @@ class ApolloImpl : Apollo {
* @return An array of mnemonic phrases.
*/
override fun createRandomMnemonics(): Array<String> {
return Mnemonic.createRandomMnemonics()
return Mnemonic.createRandomMnemonics().toTypedArray()
}

/**
Expand All @@ -47,7 +47,7 @@ class ApolloImpl : Apollo {
*/
@Throws(MnemonicLengthException::class)
override fun createSeed(mnemonics: Array<String>, passphrase: String): Seed {
return Seed(Mnemonic.createSeed(mnemonics, passphrase))
return Seed(Mnemonic.createSeed(mnemonics.asList(), passphrase))
}

/**
Expand All @@ -62,7 +62,7 @@ class ApolloImpl : Apollo {
mnemonics,
Seed(
value = Mnemonic.createSeed(
mnemonics = mnemonics,
mnemonics = mnemonics.asList(),
passphrase = passphrase ?: ""
)
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,12 @@ import io.iohk.atala.prism.walletsdk.prismagent.protocols.outOfBand.PrismOnboard
import io.iohk.atala.prism.walletsdk.prismagent.protocols.proofOfPresentation.Presentation
import io.iohk.atala.prism.walletsdk.prismagent.protocols.proofOfPresentation.RequestPresentation
import io.ktor.client.plugins.contentnegotiation.ContentNegotiation
import io.ktor.http.Url
import io.ktor.http.ContentType
import io.ktor.http.HttpMethod
import io.ktor.http.Url
import io.ktor.serialization.kotlinx.json.json
import java.net.UnknownHostException
import java.time.Duration
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.Job
Expand All @@ -80,8 +82,6 @@ import kotlinx.serialization.encodeToString
import kotlinx.serialization.json.Json
import kotlinx.serialization.json.JsonObject
import kotlinx.serialization.json.jsonObject
import java.net.UnknownHostException
import java.time.Duration

/* ktlint-disable import-ordering */

Expand Down Expand Up @@ -554,6 +554,7 @@ class PrismAgent {
return when (pollux.extractCredentialFormatFromMessage(offer.attachments)) {
CredentialType.JWT -> {
val privateKeyKeyPath = pluto.getPrismDIDKeyPathIndex(did).first()

val keyPair = Secp256k1KeyPair.generateKeyPair(
seed,
KeyCurve(Curve.SECP256K1, privateKeyKeyPath)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
package io.iohk.atala.prism.walletsdk.apollo

import io.iohk.atala.prism.apollo.base64.base64UrlEncoded
import io.iohk.atala.prism.apollo.derivation.Mnemonic
import io.iohk.atala.prism.apollo.derivation.MnemonicHelper
import io.iohk.atala.prism.apollo.utils.ECConfig
import io.iohk.atala.prism.apollo.utils.Mnemonic
import io.iohk.atala.prism.walletsdk.apollo.derivation.bip39Vectors
import io.iohk.atala.prism.walletsdk.apollo.helpers.BytesOps
import io.iohk.atala.prism.walletsdk.apollo.utils.Ed25519KeyPair
Expand Down Expand Up @@ -70,7 +71,7 @@ class ApolloTests {
@Test
fun testFailWhenInvalidWordIsUsed() {
val mnemonicCode = arrayOf("hocus", "pocus", "mnemo", "codus") + Array(24) { "abandon" }
assertFailsWith<Mnemonic.Companion.InvalidMnemonicCode> {
assertFailsWith<MnemonicHelper.Companion.InvalidMnemonicCode> {
apollo.createSeed(mnemonicCode, "")
}
}
Expand Down Expand Up @@ -113,7 +114,7 @@ class ApolloTests {

@Test
fun testCreateKeyPair_whenUsingSeedAndMnemonics_thenKeyPairIsCorrect() {
val mnemonics = arrayOf(
val mnemonics = listOf(
"blade",
"multiply",
"coil",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ package io.iohk.atala.prism.walletsdk.prismagent

/* ktlint-disable import-ordering */
import anoncreds_wrapper.LinkSecret
import io.iohk.atala.prism.apollo.utils.Mnemonic
import io.iohk.atala.prism.apollo.derivation.Mnemonic
import io.iohk.atala.prism.walletsdk.apollo.ApolloImpl
import io.iohk.atala.prism.walletsdk.apollo.utils.Secp256k1KeyPair
import io.iohk.atala.prism.walletsdk.castor.CastorImpl
Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ kotlin.code.style = official
android.useAndroidX = true
kotlin.mpp.enableCInteropCommonization = true
kotlin.native.cacheKind.iosSimulatorArm64 = none
apollo_version = 1.0.2
apollo_version = 1.0.15
didpeer_version = 1.0.4-alpha
kotlin.mpp.androidSourceSetLayoutVersion = 2
kotlinx.atomicfu.enableJvmIrTransformation = true
Expand Down