feat: SD-JWT verification #208
Check failed
There are 6 commits incorrectly signed off, the check did not pass.
Summary
| Sha | Message | Pass or fail reason | |
|---|---|---|---|
| 🟢 | 51aa7d4 | feat: verification sd-jwt | Valid sign-off found |
| 🟢 | 2ca7155 | feat: verify jwt verification after changes | Valid sign-off found |
| 🟢 | 12dec3f | Merge branch 'main' into feature/ATL-6862 | Skipped: sign-off not required in merge commit |
| 🟢 | 9e351e1 | feat: request credential support for SD-JWT | Valid sign-off found |
| 🟢 | cf9e827 | feat: verification sd-jwt | Valid sign-off found |
| 🟢 | 5ae06cb | Merge branch 'main' into feature/ATL-6862 | Skipped: sign-off not required in merge commit |
| 🟢 | 63f547b | feat: SD-JWT verification | Valid sign-off found |
| 🟢 | 38a2fc6 | feat: SD-JWT verification | Valid sign-off found |
| 🟢 | 4b77970 | feat: SD-JWT verification ready to test | Valid sign-off found |
| 🟢 | 877e948 | refactor: clean up code, remove deprecated unit te... | Valid sign-off found |
| 🟢 | 51f4948 | breaking change: remove deprecated methods | Valid sign-off found |
| 🟢 | 9b4c0b9 | Merge branch 'main' into feature/ATL-6862 | Skipped: sign-off not required in merge commit |
| 🟢 | 490e970 | fix: linting issues | Valid sign-off found |
| 🟢 | e052705 | fix: linting issues | Valid sign-off found |
| 🟢 | 5355e93 | fix: linting issues | Valid sign-off found |
| 🟢 | e729ac6 | fix: linting issues | Valid sign-off found |
| 🟢 | 7165cb2 | fix: linting issues | Valid sign-off found |
| 🟢 | 0e1feaf | feat: create prism did with Ed25519 | Valid sign-off found |
| 🟢 | 462e44e | feat: prism did support for Ed25519 | Valid sign-off found |
| 🔴 | 553247c | fix: Edge Agent should not be calling Apollo class... | Sign-off not found |
| 🔴 | 052a206 | fix: fix tests | Sign-off not found |
| 🔴 | e073390 | fix: improve pollux impl code | Sign-off not found |
| 🔴 | 0343bc7 | fix: linting issues | Sign-off not found |
| 🔴 | ab8ec6a | fix: improvements for ed25519 sdjwt signatures | Sign-off not found |
| 🔴 | 42132a3 | fix: add tests for sdjwt | Sign-off not found |
Errors details
Sign-off not found
No sign-off was found in the commit message. This usually means that the author or committer of this commit failed to include a Signed-off-by line in the commit message. In some cases, this error can also be raised if the sign-off is not in the correct format.
To avoid having pull requests blocked in the future, always include a Signed-off-by: User1 <user1@email.test> line in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).
How to fix missing or invalid sign-offs
Option 1: add remediation commit
Remediation commits are not allowed for this repository. For more details about how to enable them, please see the documentation.
Option 2: fix commits without sign-off
Rebase the branch
If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").
Warning
You should only do this if:
- You are the only author of the commits in this branch
- You are absolutely certain nobody else is doing any work based upon this branch
- There are no empty commits in the branch
To add your Signed-off-by line to every commit in this branch:
- Ensure you have a local copy of your branch by checking out the pull request locally via command line.
- In your local branch, run:
git rebase HEAD~25 --signoff - Force push your changes to overwrite the branch:
git push --force-with-lease origin feature/ATL-6862