use project name to name docker image and iexec app #69
+46
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -38,6 +43,8 @@ export async function deploy() { | |||
| throw Error('Invalid version'); | |||
| } | |||
|
|
|||
| const imageTag = `${dockerhubUsername}/${projectNameToImageName(projectName)}:${iAppVersion}`; | |||
There was a problem hiding this comment.
moved up because it can throw and its always good to throw early
Comment on lines
-40
to
-49
| // Read package.json file | ||
| export async function readPackageJonConfig() { | ||
| try { | ||
| const packageContent = await readFile('./package.json', 'utf8'); | ||
| return JSON.parse(packageContent); | ||
| } catch { | ||
| throw Error('Failed to read `package.json` file.'); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
get rid of JS template specific code 🎉
Comment on lines
+40
to
+42
| return fromError(e) | ||
| .details.map((issue) => issue.message) | ||
| .join('; '); |
There was a problem hiding this comment.
I would have preferred something simpler but didn't manage to achieve it without printing Validation error. Open for suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use project name to name docker image and iexec app
package.json(JS specific) withprojectNamedefined iniapp.cof.json