Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Learning snippets: Switch to ESM, update dependencies #1167

Merged
merged 5 commits into from
Jan 31, 2025
Merged

Learning snippets: Switch to ESM, update dependencies #1167

merged 5 commits into from
Jan 31, 2025

Conversation

grigasp
Copy link
Member

@grigasp grigasp commented Jan 30, 2025 •
edited
Loading

  • Use AppUI 5.0
  • Update the package to ESM
  • Update TS to 5.6 to support using keyword
  • Cleanup the tests a bit (e.g. moves duplicate initialization into a separate source file)
  • In tests that require calling cleanup() at the end, use "disposable" pattern

@grigasp grigasp requested review from a team as code owners January 30, 2025 12:28
saskliutas
saskliutas approved these changes Jan 30, 2025
View reviewed changes
apps/learning-snippets/tsconfig.json Outdated Show resolved Hide resolved
@grigasp @saskliutas
Update apps/learning-snippets/tsconfig.json
af8b8bf 
Co-authored-by: Saulius Skliutas <24278440+saskliutas@users.noreply.github.com>
@grigasp grigasp merged commit 979142b into master Jan 31, 2025
14 checks passed
@grigasp grigasp deleted the learning-snippets/esm branch January 31, 2025 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aruniverse aruniverse aruniverse approved these changes

@saskliutas saskliutas saskliutas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grigasp @aruniverse @saskliutas