Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust modeled element / subModel visibility #1183

Merged
merged 31 commits into from
Feb 13, 2025
Merged

Adjust modeled element / subModel visibility #1183

merged 31 commits into from
Feb 13, 2025

Conversation

JonasDov
Copy link
Contributor

@JonasDov JonasDov commented Feb 7, 2025

closes #1163

@JonasDov JonasDov requested review from a team as code owners February 7, 2025 12:15
JonasDov and others added 11 commits February 11, 2025 11:57
@JonasDov @grigasp
Update packages/itwin/tree-widget/public/locales/en/TreeWidget.json
2f7a647 
Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
@JonasDov @grigasp
Update packages/itwin/tree-widget/src/tree-widget-react/components/tr…
c04478a 
…ees/models-tree/internal/ModelsTreeIdsCache.ts

Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
@JonasDov @grigasp
Update packages/itwin/tree-widget/src/tree-widget-react/components/tr…
6d62669 
…ees/models-tree/internal/ModelsTreeIdsCache.ts

Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
@JonasDov @grigasp
Update change/@itwin-tree-widget-react-d7414fdf-e366-4667-8371-cb9c44…
783efeb 
…451319.json

Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
@JonasDov @grigasp
Update packages/itwin/tree-widget/src/test/trees/models-tree/internal…
317e819 
…/ModelsTreeVisibilityHandler.test.ts

Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
@JonasDov
Remove unnecessary promise.all and create keyy once
e5094da
@JonasDov
Rename modelId to modeledElementId
6592eee
@JonasDov
Rename getDoesSubModelExist -> hasSubModel
7904ec9
@JonasDov
Rename shouldntChangeSubModels to skipSubModels
83d305b
@JonasDov
Adress comments
9265d75
@JonasDov
Remove unused locale
c19077a
grigasp
grigasp reviewed Feb 12, 2025
View reviewed changes
...es/itwin/tree-widget/src/test/trees/models-tree/internal/ModelsTreeVisibilityHandler.test.ts Outdated Show resolved Hide resolved
...es/itwin/tree-widget/src/test/trees/models-tree/internal/ModelsTreeVisibilityHandler.test.ts Outdated Show resolved Hide resolved
...es/itwin/tree-widget/src/test/trees/models-tree/internal/ModelsTreeVisibilityHandler.test.ts Outdated Show resolved Hide resolved
...es/itwin/tree-widget/src/test/trees/models-tree/internal/ModelsTreeVisibilityHandler.test.ts Outdated Show resolved Hide resolved
...es/itwin/tree-widget/src/test/trees/models-tree/internal/ModelsTreeVisibilityHandler.test.ts Outdated Show resolved Hide resolved
...es/itwin/tree-widget/src/test/trees/models-tree/internal/ModelsTreeVisibilityHandler.test.ts Outdated Show resolved Hide resolved
...es/itwin/tree-widget/src/test/trees/models-tree/internal/ModelsTreeVisibilityHandler.test.ts Outdated Show resolved Hide resolved
...es/itwin/tree-widget/src/test/trees/models-tree/internal/ModelsTreeVisibilityHandler.test.ts Outdated Show resolved Hide resolved
...es/itwin/tree-widget/src/test/trees/models-tree/internal/ModelsTreeVisibilityHandler.test.ts Outdated Show resolved Hide resolved
...t/src/tree-widget-react/components/trees/models-tree/internal/ModelsTreeVisibilityHandler.ts Outdated Show resolved Hide resolved
JonasDov and others added 10 commits February 12, 2025 11:00
@JonasDov @grigasp
Update packages/itwin/tree-widget/src/test/trees/models-tree/internal…
1c73c42 
…/ModelsTreeVisibilityHandler.test.ts

Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
@JonasDov @grigasp
Update packages/itwin/tree-widget/src/test/trees/models-tree/internal…
1db957b 
…/ModelsTreeVisibilityHandler.test.ts

Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
@JonasDov @grigasp
Update packages/itwin/tree-widget/src/test/trees/models-tree/internal…
fdf180c 
…/ModelsTreeVisibilityHandler.test.ts

Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
@JonasDov @grigasp
Update packages/itwin/tree-widget/src/test/trees/models-tree/internal…
b32a434 
…/ModelsTreeVisibilityHandler.test.ts

Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
@JonasDov @grigasp
Update packages/itwin/tree-widget/src/test/trees/models-tree/internal…
040a23f 
…/ModelsTreeVisibilityHandler.test.ts

Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
@JonasDov @grigasp
Update packages/itwin/tree-widget/src/test/trees/models-tree/internal…
cf96631 
…/ModelsTreeVisibilityHandler.test.ts

Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
@JonasDov @grigasp
Update packages/itwin/tree-widget/src/test/trees/models-tree/internal…
166b65d 
…/ModelsTreeVisibilityHandler.test.ts

Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
@JonasDov @grigasp
Update packages/itwin/tree-widget/src/test/trees/models-tree/internal…
d5d3d9c 
…/ModelsTreeVisibilityHandler.test.ts

Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
@JonasDov
Adress comments
f49030b
@JonasDov
Merge branch 'master' into JonasD/modeled-element-visibility-fix
afb8768
grigasp
grigasp reviewed Feb 13, 2025
View reviewed changes
...t/src/tree-widget-react/components/trees/models-tree/internal/ModelsTreeVisibilityHandler.ts Outdated Show resolved Hide resolved
...t/src/tree-widget-react/components/trees/models-tree/internal/ModelsTreeVisibilityHandler.ts Outdated Show resolved Hide resolved
packages/itwin/tree-widget/public/locales/en/TreeWidget.json Outdated Show resolved Hide resolved
...t/src/tree-widget-react/components/trees/models-tree/internal/ModelsTreeVisibilityHandler.ts Outdated Show resolved Hide resolved
...t/src/tree-widget-react/components/trees/models-tree/internal/ModelsTreeVisibilityHandler.ts Outdated Show resolved Hide resolved
...t/src/tree-widget-react/components/trees/models-tree/internal/ModelsTreeVisibilityHandler.ts Outdated Show resolved Hide resolved
...t/src/tree-widget-react/components/trees/models-tree/internal/ModelsTreeVisibilityHandler.ts Outdated Show resolved Hide resolved
...t/src/tree-widget-react/components/trees/models-tree/internal/ModelsTreeVisibilityHandler.ts Show resolved Hide resolved
...t/src/tree-widget-react/components/trees/models-tree/internal/ModelsTreeVisibilityHandler.ts Outdated Show resolved Hide resolved
JonasDov and others added 5 commits February 13, 2025 10:34
@JonasDov @grigasp
Update packages/itwin/tree-widget/src/tree-widget-react/components/tr…
bc5d354 
…ees/models-tree/internal/ModelsTreeVisibilityHandler.ts

Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
@JonasDov @grigasp
Update packages/itwin/tree-widget/public/locales/en/TreeWidget.json
7c15883 
Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
@JonasDov
Adress comments
a6f7e14
@JonasDov
Rename getPotentialSubModelVisibilityStatus -> getPotentialSubModelsV…
999b33a 
…isibilityStatus
@JonasDov
Adress comments
7b65ba2
@JonasDov JonasDov merged commit 9d9f47d into master Feb 13, 2025
14 checks passed
@JonasDov JonasDov deleted the JonasD/modeled-element-visibility-fix branch February 13, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grigasp grigasp grigasp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tree widget: Modeled element / Sub-model visibility controls in Models tree are inconsistent
2 participants
@JonasDov @grigasp