Improve ElementSubdomainModifier #27899
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There have been several bug reports and feature requests since the introduction of `ElementSubdomainModifier`. This PR fixes most, if not all, of the bugs and introduces a new feature. Notable changes: - `meshChanged()` is now only called when at least one element changes its subdomain. The old behavior led to an adaptivity file (*-s0*.e) file at every time step. - A new input parameter "active_subdomain" asks for _active_ subdomains on which the equation system exists. This enables the detection of newly activated dofs so that variable initialization and material property initialization can be properly performed. - A new input parameter "initialize_variables" allows users to choose which variables to initialize. This supports nonlinear and aux variables of any order and family. - A new input parameter "initialization_strategy" allows users to choose *how* to initialize each variable. The supported strategies are - IC: initial condition of the variable will be applied. - NEAREST: the old values of the nearest dofs (in the spatial sense) will be assigned on newly activated dofs. - CONSTANT: a constant value will be assigned on newly activated dofs. - A new input parameter "initialization_constant" additionally specifies the constant used with "initialization_strategy = CONSTANT". close idaholab#18765 close idaholab#18835 ref idaholab#21579 Also references many many discussions...
|
This pull request has been automatically marked as stale because it has not had recent activity in the last 100 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
|
Closing as superseded by #27965 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been several bug reports and feature requests since the introduction of ElementSubdomainModifier. This PR fixes most, if not all, of the bugs and introduces a new feature.
Notable changes:
meshChanged()is now only called when at least one element changes its subdomain. The old behavior led to an adaptivity file (*-s0*.e) file at every time step.close #18765
close #18835
ref #21579
Also references many many discussions...
This is an update of pull request #26254 by @hugary1995