WIP: Major refactor #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matissecallewaert
approved these changes
Oct 1, 2024
| fn update_active_idle_time(&mut self, timestamp: &DateTime<Utc>, threshold: f64) { | ||
| if timestamp.signed_duration_since(self.end_active).num_microseconds().unwrap() as f64 > threshold { | ||
| let duration = self.end_active.signed_duration_since(self.start_active); | ||
| if !duration.is_zero() { |
There was a problem hiding this comment.
Don't know if this would ever occur, but what if the duration is smaller then zero?
There was a problem hiding this comment.
signed_duration_since: Subtracts another DateTime from the current date and time. This does not overflow or underflow at all.
I expect no problems
Instead of the git repo to pull the latest version from, I changed it to an actual version. This gives us more control over the versioning as I experienced problems on different machines. This makes also sure that we don't suddenly have a broken program when Aya creates a release with breaking changes
…alue in the help menu
matissecallewaert
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.