Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ refactor ] Use List1 for determining parameters #3489

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

spcfox
Copy link
Contributor

@spcfox spcfox commented Feb 12, 2025

Description

The determining parameters are stored in List, but an empty list is never used. I suggest reflecting this in the signature with List1.

Also, the parser allows an empty list of determining parameters in interfaces, which is simply ignored during elaboration. I suggest making this a parser error:

interface Iface | where

Should this change go in the CHANGELOG?

  • If this is a fix, user-facing change, a compiler change, or a new paper
    implementation, I have updated CHANGELOG_NEXT.md (and potentially also
    CONTRIBUTORS.md).

src/Idris/Parser.idr Outdated Show resolved Hide resolved
@andrevidela
Copy link
Collaborator

looks good to me

@andrevidela andrevidela merged commit 4889328 into idris-lang:main Feb 13, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants