Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
andrew-draper authored Jan 17, 2025
1 parent bb13628 commit 0011e88
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
1 change: 0 additions & 1 deletion cddl/raw-value.cddl
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
$raw-value-type-choice /= bytes
$raw-value-type-choice /= tagged-bytes
$raw-value-type-choice /= masked-raw-value

Expand Down
7 changes: 4 additions & 3 deletions draft-ietf-rats-corim.md
Original file line number Diff line number Diff line change
Expand Up @@ -990,10 +990,11 @@ the sensitive values in memory are encrypted.
Raw value measurements are typically vendor defined values that are checked by Verifiers
for consistency only, since the security relevance is opaque to Verifiers.

A `raw-value` from Evidence or an Endorsement is a value of type `bytes` that is optionally tagged #6.560.
A `raw-value` from Evidence or an Endorsement is a tagged value of type `bytes`.
This specification defines tag #6.560.
The default raw value measurement is of type `tagged-bytes` ({{sec-common-tagged-bytes}}).

Additional raw value types can be defined, but must be a CBOR tagged `bstr`.
Additional value types can be added to `$raw-value-type-choice`, these additional values must be CBOR tagged `bstr`s.
Constraining all raw value types to be `bstr` lets Verifiers compare raw values without understanding their contents.

A raw value intended for comparison can include a mask value, which selects the bits to compare during appraisal.
Expand Down Expand Up @@ -2448,7 +2449,7 @@ The comparison MUST return false if there are no hash algorithms from the condit

A `raw-value` entry contains binary data.

The value stored under `measurement-values-map` codepoint 4 in an ACS entry must be a `raw-value` entry, which must have type `bytes`, with an optional tag.
The value stored under `measurement-values-map` codepoint 4 in an ACS entry must be a `raw-value` entry, which must be tagged and have type `bytes`.

The value stored under the condition ECT `measurement-values-map` codepoint 4 may additionally be a `masked-raw-value` entry, which specifies an expected value and a mask.

Expand Down

0 comments on commit 0011e88

Please sign in to comment.