Skip to content

Commit

Permalink
s/masked-raw-value/tagged-masked-raw-value/g
Browse files Browse the repository at this point in the history
Signed-off-by: Thomas Fossati <thomas.fossati@linaro.org>
  • Loading branch information
thomas-fossati committed Jan 22, 2025
1 parent 64f4569 commit ed005fc
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion cddl/cbor-tags.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ tagged-cert-thumbprint-type = #6.559(digest)
tagged-bytes = #6.560(bytes)
tagged-cert-path-thumbprint-type = #6.561(digest)
tagged-pkix-asn1der-cert-type = #6.562(bstr)
masked-raw-value = #6.563([
tagged-masked-raw-value = #6.563([
2 changes: 1 addition & 1 deletion cddl/masked-raw-value.cddl
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
masked-raw-value = #6.563([
tagged-masked-raw-value = #6.563([
value: bytes
mask : bytes
])
2 changes: 1 addition & 1 deletion cddl/raw-value.cddl
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
$raw-value-type-choice /= tagged-bytes
$raw-value-type-choice /= masked-raw-value
$raw-value-type-choice /= tagged-masked-raw-value

raw-value-mask-type = bytes
12 changes: 6 additions & 6 deletions draft-ietf-rats-corim.md
Original file line number Diff line number Diff line change
Expand Up @@ -1182,13 +1182,13 @@ If the search criteria are satisfied, the `endorsements` entries are asserted wi

#### Conditional Endorsement Series Triple {#sec-comid-triple-cond-series}

A Conditional Endorsement Series triple uses a "stateful environment" that identifies a Target Environment plus the measurements that have matching Evidence.
A Conditional Endorsement Series triple uses a "stateful environment" that identifies a Target Environment plus the measurements that have matching Evidence.

The series object is an array of `conditional-series-record` that has both Reference and Endorsed Values.
Each conditional-series-record record is evaluated in the order it appears in the series array.
The Endorsed Values are accepted if the series condition in a `conditional-series-record` matches the attester's actual state.
The first `conditional-series-record` that successfully matches an attester's actual state terminates the matching and the corresponding Endorsed Values are accepted.
If none of the series conditions match the attester's actual state, the triple is not matched, and no Endorsed values are accepted.
If none of the series conditions match the attester's actual state, the triple is not matched, and no Endorsed values are accepted.

More clarification about the usage and matching order will be resolved by: [^tracked-at] https://github.com/ietf-rats-wg/draft-ietf-rats-corim/issues/321

Expand Down Expand Up @@ -2451,12 +2451,12 @@ A `raw-value` entry contains binary data.

The value stored under `measurement-values-map` codepoint 4 in an ACS entry must be a `raw-value` entry, which must be tagged and have type `bytes`.

The value stored under the condition ECT `measurement-values-map` codepoint 4 may additionally be a `masked-raw-value` entry, which specifies an expected value and a mask.
The value stored under the condition ECT `measurement-values-map` codepoint 4 may additionally be a `tagged-masked-raw-value` entry, which specifies an expected value and a mask.

If the condition ECT `measurement-value-map` codepoint 4 is of `tagged-bytes`, and there is no value stored under codepoint 5, then the Verifier treats it in the same way as a `masked-raw-value` with the `value` field holding the same contents and a `mask` of the same length as the value with all bits set.
If the condition ECT `measurement-value-map` codepoint 4 is of `tagged-bytes`, and there is no value stored under codepoint 5, then the Verifier treats it in the same way as a `tagged-masked-raw-value` with the `value` field holding the same contents and a `mask` of the same length as the value with all bits set.
The standard comparison function defined in this document removes the tag before performing the comparison.

For backwards compatibility, if the condition ECT `measurement-value-map` codepoint 4 is of type `tagged-bytes`, and there is a mask stored under codepoint 5, then the Verifier treats it in the same way as a `masked-raw-value` with the `value` field holding the same contents and a `mask` holding the contents of codepoint 5.
For backwards compatibility, if the condition ECT `measurement-value-map` codepoint 4 is of type `tagged-bytes`, and there is a mask stored under codepoint 5, then the Verifier treats it in the same way as a `tagged-masked-raw-value` with the `value` field holding the same contents and a `mask` holding the contents of codepoint 5.

The comparison MUST return false if the lengths of the candidate entry value and the condition ECT value are different.

Expand Down Expand Up @@ -2612,7 +2612,7 @@ IANA is requested to allocate the following tags in the "CBOR Tags" registry {{!
| 560 | `bytes` | tagged-bytes, see {{sec-common-tagged-bytes}} | {{&SELF}} |
| 561 | `digest` | tagged-cert-path-thumbprint-type, see {{sec-crypto-keys}} | {{&SELF}} |
| 562 | `bytes` | tagged-pkix-asn1der-cert-type, see {{sec-crypto-keys}} | {{&SELF}} |
| 563 | `masked-raw-value` | masked-raw-value, see {{sec-comid-raw-value-types}} | {{&SELF}} |
| 563 | `tagged-masked-raw-value` | tagged-masked-raw-value, see {{sec-comid-raw-value-types}} | {{&SELF}} |
| 564-599 | `any` | Earmarked for CoRIM | {{&SELF}} |

Tags designated as "Earmarked for CoRIM" can be reassigned by IANA based on advice from the designated expert for the CBOR Tags registry.
Expand Down

0 comments on commit ed005fc

Please sign in to comment.