Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CoBOM to CoTL (Concise Tag List) #370

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yogeshbdeshpande
Copy link
Collaborator

@yogeshbdeshpande yogeshbdeshpande commented Jan 29, 2025

Fixes #369

@nedmsmith
Copy link
Collaborator

were there no examples that tested the cobom cddl? If not, there probably should be.

@yogeshbdeshpande
Copy link
Collaborator Author

were there no examples that tested the cobom cddl? If not, there probably should be.

No not to my knowledge!

@deeglaze
Copy link
Collaborator

This bike shed color is acceptable.

Fixes #369
Signed-off-by: Yogesh Deshpande <yogesh.deshpande@arm.com>
@thomas-fossati
Copy link
Collaborator

were there no examples that tested the cobom cddl? If not, there probably should be.

Added #371

@yogeshbdeshpande
Copy link
Collaborator Author

were there no examples that tested the cobom cddl? If not, there probably should be.

Added #371

Thanks for creating this one, I shall try to include this probably in this PR itself...

@@ -0,0 +1,6 @@
concise-tl-tag = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning: bikeshedding comment.

I'd prefer concise-tag-list because I'm not sure that CoTL is a "tag" in the sense that other Co{MID,SWID,TS} are.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would then beak the convention (we have as of today) that CoRIM contains a list of tags!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also OK with adding a new code point for concise-tag-list to corim-map as I agree with Thomas that I don't think these are the same type thing as comid, coswid, etc.

corim-map = {
...
? &(tag-list: 6) => [ + concise-tl-tag ]
...
}

Copy link
Collaborator Author

@yogeshbdeshpande yogeshbdeshpande Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets separate two discussions.

  1. Rename CoBOM to CoTL --> This is addressed here
  2. Discuss whether CoTL is a tag in itself or another data structure ? Discussed via Issue Is CoTL (old CoBOM) really a tag? #372

Copy link
Collaborator

@nedmsmith nedmsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but probably should have some examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename CoBOM to a suitable name
4 participants