-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename CoBOM to CoTL (Concise Tag List) #370
base: main
Are you sure you want to change the base?
Conversation
were there no examples that tested the cobom cddl? If not, there probably should be. |
No not to my knowledge! |
This bike shed color is acceptable. |
Fixes #369 Signed-off-by: Yogesh Deshpande <yogesh.deshpande@arm.com>
167bdcc
to
60da335
Compare
Added #371 |
Thanks for creating this one, I shall try to include this probably in this PR itself... |
@@ -0,0 +1,6 @@ | |||
concise-tl-tag = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warning: bikeshedding comment.
I'd prefer concise-tag-list
because I'm not sure that CoTL is a "tag" in the sense that other Co{MID,SWID,TS} are.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would then beak the convention (we have as of today) that CoRIM contains a list of tags
!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also OK with adding a new code point for concise-tag-list
to corim-map
as I agree with Thomas that I don't think these are the same type thing as comid, coswid, etc.
corim-map = {
...
? &(tag-list: 6) => [ + concise-tl-tag ]
...
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets separate two discussions.
- Rename CoBOM to CoTL --> This is addressed here
- Discuss whether CoTL is a tag in itself or another data structure ? Discussed via Issue Is CoTL (old CoBOM) really a tag? #372
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - but probably should have some examples.
Fixes #369