fix. params. test vars

x/launch/keeper/msg_update_params_test.go

@@ -35,7 +35,9 @@ func TestMsgUpdateParams(t *testing.T) {
 			name: "send enabled param",
 			input: &types.MsgUpdateParams{
 				Authority: k.GetAuthority(),
-				Params:    types.Params{},
+				Params: types.Params{
+					RevertDelay: types.DefaultRevertDelay,
+				},
 			},
 		},
 		{
@@ -49,7 +51,6 @@ func TestMsgUpdateParams(t *testing.T) {
 	for _, tc := range testCases {
 		t.Run(tc.name, func(t *testing.T) {
 			_, err := ms.UpdateParams(ctx, tc.input)
-
 			if tc.err != nil {
 				require.Error(t, err)
 				require.ErrorIs(t, err, tc.err)

x/launch/types/params.go

@@ -2,7 +2,6 @@ package types
 
 import (
 	"errors"
-	"fmt"
 	"time"
 
 	sdk "github.com/cosmos/cosmos-sdk/types"
@@ -75,21 +74,13 @@ func (p Params) Validate() error {
 	if err := validateRevertDelay(p.RevertDelay); err != nil {
 		return err
 	}
-	if err := validateMaxMetadataLength(p.MaxMetadataLength); err != nil {
-		return err
-	}
 	if err := p.ChainCreationFee.Validate(); err != nil {
 		return err
 	}
 	return p.RequestFee.Validate()
 }
 
-func validateLaunchTimeRange(i interface{}) error {
-	v, ok := i.(LaunchTimeRange)
-	if !ok {
-		return fmt.Errorf("invalid parameter type: %T", i)
-	}
-
+func validateLaunchTimeRange(v LaunchTimeRange) error {
 	// it is enough to check that minLaunchTime is positive since it must be that minLaunchTime < maxLaunchTime
 	if v.MinLaunchTime < 0 {
 		return errors.New("MinLaunchTime can't be negative")
@@ -106,12 +97,7 @@ func validateLaunchTimeRange(i interface{}) error {
 	return nil
 }
 
-func validateRevertDelay(i interface{}) error {
-	v, ok := i.(time.Duration)
-	if !ok {
-		return fmt.Errorf("invalid parameter type: %T", i)
-	}
-
+func validateRevertDelay(v time.Duration) error {
 	if v > MaxParametrableRevertDelay {
 		return errors.New("max parametrable revert delay reached")
 	}
@@ -123,21 +109,6 @@ func validateRevertDelay(i interface{}) error {
 	return nil
 }
 
-func validateRequestFee(i interface{}) error {
-	v, ok := i.(sdk.Coins)
-	if !ok {
-		return fmt.Errorf("invalid parameter type: %T", i)
-	}
-	return v.Validate()
-}
-
-func validateMaxMetadataLength(i interface{}) error {
-	if _, ok := i.(uint64); !ok {
-		return fmt.Errorf("invalid parameter type: %T", i)
-	}
-	return nil
-}
-
 func (l *LaunchTimeRange) Equal(cmp *LaunchTimeRange) bool {
 	switch {
 	case l.GetMinLaunchTime().Nanoseconds() != cmp.GetMinLaunchTime().Nanoseconds():

x/monitoringp/types/params.go

@@ -61,12 +61,7 @@ func (p Params) Validate() error {
 }
 
 // validateLastBlockHeight validates last block height
-func validateLastBlockHeight(i interface{}) error {
-	lastBlockHeight, ok := i.(int64)
-	if !ok {
-		return fmt.Errorf("invalid parameter type: %T", i)
-	}
-
+func validateLastBlockHeight(lastBlockHeight int64) error {
 	if lastBlockHeight <= 0 {
 		return errors.New("last block height can't be 0 or negative")
 	}
@@ -75,12 +70,7 @@ func validateLastBlockHeight(i interface{}) error {
 }
 
 // validateConsumerConsensusState validates consumer consensus state
-func validateConsumerConsensusState(i interface{}) error {
-	ccs, ok := i.(networktypes.ConsensusState)
-	if !ok {
-		return fmt.Errorf("invalid parameter type: %T", i)
-	}
-
+func validateConsumerConsensusState(ccs networktypes.ConsensusState) error {
 	// perform the verification only if the Consumer Consensus State is defined
 	// TODO: remove this check and set an official Network mainnet consensus state as default
 	if ccs.Timestamp != "" {
@@ -96,12 +86,7 @@ func validateConsumerConsensusState(i interface{}) error {
 }
 
 // validateConsumerChainID validates consumer chain ID
-func validateConsumerChainID(i interface{}) error {
-	chainID, ok := i.(string)
-	if !ok {
-		return fmt.Errorf("invalid parameter type: %T", i)
-	}
-
+func validateConsumerChainID(chainID string) error {
 	_, _, err := chainid.ParseGenesisChainID(chainID)
 	if err != nil {
 		return errors.Wrap(err, "invalid chain ID param")
@@ -110,12 +95,7 @@ func validateConsumerChainID(i interface{}) error {
 }
 
 // validateConsumerUnbondingPeriod validates consumer unbonding period
-func validateConsumerUnbondingPeriod(i interface{}) error {
-	unbondingPeriod, ok := i.(int64)
-	if !ok {
-		return fmt.Errorf("invalid parameter type: %T", i)
-	}
-
+func validateConsumerUnbondingPeriod(unbondingPeriod int64) error {
 	if unbondingPeriod < networktypes.MinimalUnbondingPeriod {
 		return fmt.Errorf("minimal unbonding period is %d", networktypes.MinimalUnbondingPeriod)
 	}
@@ -124,12 +104,7 @@ func validateConsumerUnbondingPeriod(i interface{}) error {
 }
 
 // validateConsumerRevisionHeight validates consumer revision height
-func validateConsumerRevisionHeight(i interface{}) error {
-	revisionHeight, ok := i.(uint64)
-	if !ok {
-		return fmt.Errorf("invalid parameter type: %T", i)
-	}
-
+func validateConsumerRevisionHeight(revisionHeight uint64) error {
 	if revisionHeight == 0 {
 		return fmt.Errorf("minimal revision height is %d", 1)
 	}

x/participation/keeper/msg_server_participate_test.go

@@ -125,7 +125,7 @@ func Test_msgServer_Participate(t *testing.T) {
 				AuctionID:   auctionRegistrationPeriodID,
 				TierID:      1,
 			},
-			err:       types.ErrInvalidAddress,
+			err:       types.ErrInvalidSigner,
 			blockTime: validRegistrationTime,
 		},
 		{

x/participation/keeper/msg_update_params_test.go

@@ -35,7 +35,11 @@ func TestMsgUpdateParams(t *testing.T) {
 			name: "send enabled param",
 			input: &types.MsgUpdateParams{
 				Authority: k.GetAuthority(),
-				Params:    types.Params{},
+				Params: types.Params{
+					AllocationPrice:    types.DefaultAllocationPrice,
+					RegistrationPeriod: types.DefaultRegistrationPeriod,
+					WithdrawalDelay:    types.DefaultWithdrawalDelay,
+				},
 			},
 		},
 		{

x/participation/types/params.go

@@ -93,12 +93,7 @@ func (p Params) Validate() error {
 }
 
 // validateAllocationPrice validates the AllocationPrice param
-func validateAllocationPrice(v interface{}) error {
-	allocationPrice, ok := v.(AllocationPrice)
-	if !ok {
-		return fmt.Errorf("invalid parameter type: %T", v)
-	}
-
+func validateAllocationPrice(allocationPrice AllocationPrice) error {
 	if allocationPrice.Bonded.IsNil() {
 		return errors.New("value for 'bonded' should be set")
 	}
@@ -111,16 +106,11 @@ func validateAllocationPrice(v interface{}) error {
 }
 
 // validateParticipationTierList validates the ParticipationTierList param
-func validateParticipationTierList(v interface{}) error {
-	participationTierList, ok := v.([]Tier)
-	if !ok {
-		return fmt.Errorf("invalid parameter type: %T", v)
-	}
-
+func validateParticipationTierList(participationTierList []Tier) error {
 	tiersIndexMap := make(map[uint64]struct{})
 	for _, tier := range participationTierList {
 		// check IDs are unique
-		if _, ok = tiersIndexMap[tier.TierID]; ok {
+		if _, ok := tiersIndexMap[tier.TierID]; ok {
 			return fmt.Errorf("duplicated tier ID: %v", tier.TierID)
 		}
 		tiersIndexMap[tier.TierID] = struct{}{}
@@ -150,12 +140,7 @@ func validateTierBenefits(b TierBenefits) error {
 }
 
 // validateTimeDuration validates a time.Duration parameter
-func validateTimeDuration(i interface{}) error {
-	v, ok := i.(time.Duration)
-	if !ok {
-		return fmt.Errorf("invalid parameter type: %T", i)
-	}
-
+func validateTimeDuration(v time.Duration) error {
 	if v <= 0 {
 		return fmt.Errorf("time frame must be positive")
 	}

x/project/types/params.go

@@ -1,8 +1,6 @@
 package types
 
 import (
-	"fmt"
-
 	sdkmath "cosmossdk.io/math"
 	sdk "github.com/cosmos/cosmos-sdk/types"
 )
@@ -54,36 +52,17 @@ func (p Params) Validate() error {
 	if err := validateProjectCreationFee(p.ProjectCreationFee); err != nil {
 		return err
 	}
-	if err := validateMaxMetadataLength(p.MaxMetadataLength); err != nil {
-		return err
-	}
-
 	return p.ProjectCreationFee.Validate()
 }
 
-func validateTotalSupplyRange(i interface{}) error {
-	v, ok := i.(TotalSupplyRange)
-	if !ok {
-		return fmt.Errorf("invalid parameter type: %T", i)
-	}
+func validateTotalSupplyRange(v TotalSupplyRange) error {
 	if err := v.ValidateBasic(); err != nil {
 		return err
 	}
 
 	return nil
 }
 
-func validateProjectCreationFee(i interface{}) error {
-	v, ok := i.(sdk.Coins)
-	if !ok {
-		return fmt.Errorf("invalid parameter type: %T", i)
-	}
+func validateProjectCreationFee(v sdk.Coins) error {
 	return v.Validate()
 }
-
-func validateMaxMetadataLength(i interface{}) error {
-	if _, ok := i.(uint64); !ok {
-		return fmt.Errorf("invalid parameter type: %T", i)
-	}
-	return nil
-}