Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Throttler + FrequencyCalculator, add PausableLoopingThread (to be renamed) #34

Closed
wants to merge 2 commits into from
Closed

Move Throttler + FrequencyCalculator, add PausableLoopingThread (to be renamed) #34

wants to merge 2 commits into from

Conversation

TomaszTB
Copy link
Contributor

No description provided.

@TomaszTB TomaszTB requested review from calvertdw and ds58 October 31, 2024 22:32
@TomaszTB
Copy link
Contributor Author

Not sure what to do about ThrottlerAndFrequencyCounterTest. Should we move FrequencyCalculator to here too?

@TomaszTB
Copy link
Contributor Author

TomaszTB commented Nov 1, 2024

Perhaps Throttler should go in commons/time instead of commons/thread?

@calvertdw
Copy link
Member

Not sure what to do about ThrottlerAndFrequencyCounterTest. Should we move FrequencyCalculator to here too?

Yes

@TomaszTB TomaszTB marked this pull request as draft November 1, 2024 15:33
@TomaszTB TomaszTB changed the title Move Throttler to ihmc-commons Move Throttler + FrequencyCalculator, add PausableLoopingThread (to be renamed) Nov 1, 2024
@TomaszTB TomaszTB mentioned this pull request Nov 1, 2024
Closed
@TomaszTB
Copy link
Contributor Author

TomaszTB commented Nov 1, 2024

Making PR with history preserved

@TomaszTB TomaszTB closed this Nov 1, 2024
@TomaszTB TomaszTB deleted the move-throttler-to-commons branch November 12, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ds58 ds58 ds58 approved these changes

@calvertdw calvertdw Awaiting requested review from calvertdw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomaszTB @calvertdw @ds58