RepeatingTaskThread #36
Conversation
TomaszTB
force-pushed
the
feature/repeating-task-thread
branch
from
ea23027 to
ccad200
Compare
| * | ||
| * @return {@code false} if {@link #kill()} or {@link #blockingKill()} has been called. {@code true} otherwise. | ||
| */ | ||
| public boolean isRunning() |
There was a problem hiding this comment.
This method is extremely similar to isAlive(). Should it be kept?
There was a problem hiding this comment.
Nope, I can't think of a place where I'd use it
There was a problem hiding this comment.
isRunning() and isRepeating are not intuitive. I would just provide getCompleted and getRemaining
There was a problem hiding this comment.
I can remove isRunning, but I'll probably keep isRepeating package private to use in tests. It is handy there
| * remains interrupted. | ||
| */ | ||
| // Uses ThreadTools.parkAtLeast, which will not throw InterruptedException, but | ||
| // will return early when this thread is interrupted. |
There was a problem hiding this comment.
I think this is false, because parkAtLeast loops until the desired time has elapsed. It might just free spin if parkNanos is returning immediately due to the interrupt. We should probably fix that haha.
| // clear interrupted status | ||
| interrupted(); | ||
| // clears interrupted status from | ||
| if (interrupted() && executionState.getScheduled() == 0L) |
There was a problem hiding this comment.
I agree with this behavior. But what about clearing the interrupt status somewhere else, so it doesn't depend on whether the thread is throttled?
calvertdw
force-pushed
the
feature/repeating-task-thread
branch
from
6e66dd0 to
aa83295
Compare
Co-authored-by: Duncan Calvert <dcalvert@ihmc.org>
calvertdw
force-pushed
the
feature/repeating-task-thread
branch
from
609561c to
77b5148
Compare
Replacement for
RestartableThreadandRestartableThrottledThread!