Scene graph demo improvements #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ds58
commented
Feb 21, 2025
ds58
commented
- Fixes a somewhat common crashing bug related to the ZED SVO recorder panel
- Adds a utility for ensuring you have a GPU of some minimum spec (In the RDXSceneGraphDemo, this was problematic because ZED Neural mode takes so much GPU it is super laggy on lower end spec or laptops). This utility could also be useful other places.
TomaszTB
reviewed
Feb 21, 2025
| @@ -63,6 +65,61 @@ public static boolean hasCUDADevice() | |||
| return getCUDADeviceCount() > 0; | |||
| } | |||
|
|
|||
| public static String getFirstDeviceName() | |||
There was a problem hiding this comment.
You're right. I changed it to getDeviceName(int device)
| @@ -155,6 +157,11 @@ protected boolean startSensor() | |||
| return true; | |||
| } | |||
|
|
|||
| public void disableNeuralMode(boolean disableNeuralMode) | |||
There was a problem hiding this comment.
Maybe the depth mode should be a constructor parameter? That way we can pass in whatever depth mode we want. It would allow us to use different modes on a case-by-case basis
There was a problem hiding this comment.
That's a good idea. Much better.
TomaszTB
approved these changes
Feb 24, 2025
calvertdw
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.