[Feature] Sped Up Height Map Renderer #699
Merged
+177
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomaszTB
force-pushed
the
feature/fast-height-map-renderer
branch
from
8e06b12 to
b7308d2
Compare
PotatoPeeler3000
approved these changes
Feb 28, 2025
| } | ||
|
|
||
| @Override | ||
| public void getRenderables(Array<Renderable> renderables, Pool<Renderable> pool) | ||
| { | ||
| renderables.add(renderable); | ||
| if (renderable != null) |
There was a problem hiding this comment.
If we create the renderable as a field = new Renderable();, we can remove this null check. And we can remove the call in the create(int maxCells) method that created the new object for the renderable. Saves a line, and removes the confusion around the null check.
| shader.init(renderable); | ||
| renderable.shader = shader.getBaseShader(); | ||
|
|
||
| LogTools.info("Vertex Buffer Size: {}", totalCells * FLOATS_PER_CELL); | ||
| intermediateVertexBuffer = new float[totalCells * FLOATS_PER_CELL]; | ||
| LogTools.info("Vertex Buffer Size: {}", maxCells * FLOATS_PER_CELL); |
There was a problem hiding this comment.
Do you find this LogTools useful? I'd say we can remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.