few test improvements #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not run each test for each supported auth-type. Currently master runs each test for 'store', 'credential-store' and 'creds' auth types. There's no need to run each test with each auth type alias. This patch changes this by always running tests with 'store' auth type, and introducing a separate tests to verify that aliases works.
Even though type annotations are nasty, they do bring one significant benefit - the code completion in text editors becomes much better. This patch adds type annotations to python modules in the 'tests' directory.
The conftest.py today contains a hack that creates a session scoped temporary directory, and set the HTTPIE_CONFIG_DIR environment variable to that temporary directory. That previously has been done to make sure I can run tests with configuration store elsewhere. Unfortunately, this is a bit inconvenient because (1) we have to make sure there's no imports to httpie package in global scope because otherwise the patch we have won't work, (2) the creation and cleaning phase is scatted across the code base. This patch removes this hack in favor of (1) explicitly passing the temporary directory to executing httpie environment context, and (2) patching required attribute so the plugin can use the up to date version whenever it runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see commits)