Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Placeholder Value When Decryption Fails #14

Merged
merged 4 commits into from
Mar 15, 2024

Conversation

ilicmiljan
Copy link
Owner

@ilicmiljan ilicmiljan commented Mar 15, 2024

Description of Changes

Implemented the ability to specify a nullable placeholder for properties with the Encrypted attribute. This change allows for customizable handling of decryption failures, enhancing flexibility for development and production environments.

How Has This Been Tested?

Verifying that the placeholder is used correctly when decryption fails and that an exception is thrown when expected, across various scenarios.

Checklist

Please confirm the following:

  • I have tested my changes and corrected any errors.
  • I have documented my changes if necessary.

@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 3.70370% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 85.34%. Comparing base (1bc45cb) to head (a535452).

Files Patch % Lines
src/ObjectEncryptionService.php 6.66% 14 Missing ⚠️
src/Exception/SingleEncryptedAttributeExpected.php 0.00% 8 Missing ⚠️
src/Attribute/Encrypted.php 0.00% 4 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main      #14       +/-   ##
=============================================
- Coverage     96.11%   85.34%   -10.78%     
- Complexity       63       72        +9     
=============================================
  Files            17       19        +2     
  Lines           206      232       +26     
=============================================
  Hits            198      198               
- Misses            8       34       +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ilicmiljan ilicmiljan merged commit bd1e665 into main Mar 15, 2024
1 check passed
@ilicmiljan ilicmiljan deleted the add-decryption-failure-placeholder branch March 15, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants