Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency electron-updater to v6.3.0 [security] #172

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented Sep 25, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
electron-updater (source) 6.1.8 -> 6.3.0 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-39698

Observations

The file packages/electron-updater/src/windowsExecutableCodeSignatureVerifier.ts implements the signature validation routine for Electron applications on Windows. It executes the following command in a new shell (process.env.ComSpec on Windows, usually C:\Windows\System32\cmd.exe):

https://github.com/electron-userland/electron-builder/blob/140e2f0eb0df79c2a46e35024e96d0563355fc89/packages/electron-updater/src/windowsExecutableCodeSignatureVerifier.ts#L35-L41

Because of the surrounding shell, a first pass by cmd.exe expands any environment variable found in command-line above.

Exploitation

This creates a situation where verifySignature() can be tricked into validating the certificate of a different file than the one that was just downloaded. If the step is successful, the malicious update will be executed even if its signature is invalid.

Impact

This attack assumes a compromised update manifest (server compromise, Man-in-the-Middle attack if fetched over HTTP, Cross-Site Scripting to point the application to a malicious updater server, etc.).

Patch

This vulnerability was patched in #​8295, by comparing the path in the output of Get-AuthenticodeSignature with the intended one. The patch is available starting from 6.3.0-alpha.6.


Release Notes

electron-userland/electron-builder (electron-updater)

v6.3.0

Compare Source

Minor Changes
Patch Changes

v6.2.1

Compare Source

Patch Changes

v6.2.0

Compare Source

Minor Changes

v6.1.9

Compare Source

Patch Changes

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link
Author

renovate bot commented Sep 25, 2024

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: package-lock.json
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: @vue/eslint-config-standard@8.0.1
npm error Found: eslint@7.32.0
npm error node_modules/eslint
npm error   peer eslint@"^7.5.0 || ^8.0.0" from @babel/eslint-parser@7.24.1
npm error   node_modules/@babel/eslint-parser
npm error     dev @babel/eslint-parser@"^7.11.0" from the root project
npm error   peer eslint@"^6.0.0 || ^7.0.0 || >=8.0.0" from @eslint-community/eslint-utils@4.4.0
npm error   node_modules/@eslint-community/eslint-utils
npm error     @eslint-community/eslint-utils@"^4.4.0" from eslint-plugin-vue@9.25.0
npm error     node_modules/eslint-plugin-vue
npm error       peer eslint-plugin-vue@"^9.2.0" from @vue/eslint-config-standard@8.0.1
npm error       node_modules/@vue/eslint-config-standard
npm error         dev @vue/eslint-config-standard@"^8.0.0" from the root project
npm error       1 more (the root project)
npm error   12 more (eslint-plugin-n, eslint-utils, eslint-plugin-es, ...)
npm error
npm error Could not resolve dependency:
npm error peer eslint@"^8.0.1" from @vue/eslint-config-standard@8.0.1
npm error node_modules/@vue/eslint-config-standard
npm error   dev @vue/eslint-config-standard@"^8.0.0" from the root project
npm error
npm error Conflicting peer dependency: eslint@8.57.1
npm error node_modules/eslint
npm error   peer eslint@"^8.0.1" from @vue/eslint-config-standard@8.0.1
npm error   node_modules/@vue/eslint-config-standard
npm error     dev @vue/eslint-config-standard@"^8.0.0" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /runner/cache/others/npm/_logs/2025-03-03T16_38_33_199Z-eresolve-report.txt
npm error A complete log of this run can be found in: /runner/cache/others/npm/_logs/2025-03-03T16_38_33_199Z-debug-0.log

@renovate renovate bot changed the title chore(deps): update dependency electron-updater to v6.3.0 [security] chore(deps): update dependency electron-updater to v6.3.0 [security] - autoclosed Sep 25, 2024
@renovate renovate bot closed this Sep 25, 2024
@renovate renovate bot deleted the renovate/npm-electron-updater-vulnerability branch September 25, 2024 16:51
@renovate renovate bot changed the title chore(deps): update dependency electron-updater to v6.3.0 [security] - autoclosed chore(deps): update dependency electron-updater to v6.3.0 [security] Sep 26, 2024
@renovate renovate bot reopened this Sep 26, 2024
@renovate renovate bot restored the renovate/npm-electron-updater-vulnerability branch September 26, 2024 22:46
@renovate renovate bot force-pushed the renovate/npm-electron-updater-vulnerability branch from b4f014a to 1feca49 Compare September 26, 2024 22:46
@renovate renovate bot force-pushed the renovate/npm-electron-updater-vulnerability branch from 1feca49 to 1f71557 Compare October 9, 2024 07:25
@renovate renovate bot force-pushed the renovate/npm-electron-updater-vulnerability branch from 1f71557 to e223712 Compare January 23, 2025 20:21
@renovate renovate bot force-pushed the renovate/npm-electron-updater-vulnerability branch from e223712 to 651832a Compare January 30, 2025 18:32
@renovate renovate bot force-pushed the renovate/npm-electron-updater-vulnerability branch from 651832a to e5dd9c6 Compare February 9, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants