Sourcery Suggested Refactorings #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SourceryAI
commented
Feb 24, 2021
| if None in t: | ||
| p = t[None] | ||
| for j in range(len(p)): | ||
| points[i+j] = max(points[i+j], p[j]) |
There was a problem hiding this comment.
Function Hyphenator.hyphenate_word refactored with the following changes:
- Swap if/else branches (swap-if-else-branches)
- Remove unnecessary else after guard condition (remove-unnecessary-else)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
Here are 2 refactorings we found that can help improve the readability/quality of your code.
We found another 17 refactorings in your repo as well but didn't want to open too big of a PR. Add Sourcery to your repo to see the rest of them and to get these types of refactorings on every pull request.
You can also get these types of suggestions while you work in VS Code or PyCharm.
One last thing. We're sending out this PR because we think it's helpful. If it isn't please let us know! Or ignore the PR and we won't bother you again 🙂