feat(mobile): allow contact picking for names in mobile app #15817
+164
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samolego
changed the title
|
Hello, this is very cool! |
bo0tzz
changed the title
|
I've since done some other designs but was actually the most satisfied with this one. I'm marking this as open for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I love immich but thought it could use a minor improvement when naming your persons. If you do it via mobile app, we have access to user's contact list, so we can use it to suggest people names.
I've implemented that, you can see how it looks in the attached screenshots:
Here's a (very blurred) video as well, I had little time to edit but I hope you get the point:
immich.mp4
I'm opening this as a draft as design (especially of dropdown) can be improved and I'd like to get a feedback on what you think