feat: search by description #15818
Merged
feat: search by description #15818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrasm91
approved these changes
Jan 31, 2025
Snowknight26
reviewed
Feb 2, 2025
server/src/entities/asset.entity.ts
Outdated
| @@ -396,6 +396,9 @@ export function searchAssetBuilder(kysely: Kysely<DB>, options: AssetSearchBuild | |||
| sql`'%' || f_unaccent(${options.originalFileName}) || '%'`, | |||
| ), | |||
| ) | |||
| .$if(!!options.description, (qb) => | |||
| qb.innerJoin('exif', 'assets.id', 'exif.assetId').where('exif.description', 'ilike', `%${options.description}%`), | |||
There was a problem hiding this comment.
Probably want to escape the value being passed in in case there's a % in the string? Otherwise searching for 100% will return descriptions containing 100.
There was a problem hiding this comment.
I think this happens automatically by the library
|
There should be an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to search by description using postgresql text search
TODO