feat: mobile navigation sidebar menu #142
Conversation
Deploying inclusive-standards with
|
| Latest commit: |
9f1b32c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cd3dc87a.inclusive-standards.pages.dev |
| Branch Preview URL: | https://feat-project-menu.inclusive-standards.pages.dev |
| } | ||
|
|
||
| .project nav inclusive-disclosure { | ||
| padding-inline: 0; |
There was a problem hiding this comment.
We should remove top margin for this one;
margin-block-start: unset;
There was a problem hiding this comment.
I tried it and I don't agree; the focus state looks really weird with the double border at the top:
There was a problem hiding this comment.
@greatislander and @chosww, I think I can see both points here. There ends up being a lot of horizontal bars across the page, especially towards the top, such as the included screenshot. Is it possible to remove some of these horizontal bars/borders or change how the "sections" are visually indicated. I don't think it's always clear right now where things break up and in the case of the project menu is making things look less aligned than they do without the contrast theme.
Would something looking like the following be okay?
There was a problem hiding this comment.
I actually think that's probably a bigger conversation and I would prefer to open a separate issue to explore the approach we are taking to delineating sections when contrast themes are applied. Is that okay? @jobara if you want to file an issue that's good with me.
There was a problem hiding this comment.
Thanks. Let me know if this is good to merge now.
No description provided.