LMSA-9652 - added event authorization event publisher and removed the… #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… old way of doing authorization event registration
dsobiera
commented
Feb 7, 2025
| @Component | ||
| @Slf4j | ||
| public class LmsAuthorizationEventPublisher implements AuthorizationEventPublisher { | ||
| private ApplicationEventPublisher applicationEventPublisher; |
There was a problem hiding this comment.
Maybe we put this publisher in a common place (vs in the tool here) like the old stuff was? And by publisher I mean this whole class/file. The issue doing that is that anything using that common place will be publishing authorization events. And, perhaps, that's okay?
dsobiera
commented
Feb 10, 2025
|
|
||
| import java.util.function.Supplier; | ||
|
|
||
| @Profile("it12") |
There was a problem hiding this comment.
Would we want to use this profile to turn authorization event publishing on? If so, we'd have to change the runtime profiles for our apps that use this (to help community runs by leaving this off). Otherwise, we'd remove this profile and always have authorization event publishing on
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… old way of doing authorization event registration