-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for __attribute__(()) in enum/struct/union #76
base: main
Are you sure you want to change the base?
Add support for __attribute__(()) in enum/struct/union #76
Conversation
Thanks for the contribution! Could you fix the linter failure? Otherwise this LGTM. |
@inducer I just realized that at least GCC accepts multiple
But this only matches if there is an |
76dcb4a
to
776ed69
Compare
Not sure I understand. Wouldn't each |
Yes, I did not realize it actually worked because of another issue. I'm reworking the rules to allow |
Add support for GNU __attribute__(()) in enum/struct/union definitions, both on the type itself and on enumerators. Fixes inducer#42 Signed-off-by: Douglas Raillard <douglas.raillard@arm.com>
@inducer Unfortunately I stopped using pycparserext (instead of parsing a pre-existing header made by another tool, I made a tool that creates the header in the first place) and I don't have the bandwidth to fix pycparserext. Feel free to re-own this PR if someone else wants to take over. I did not go super far in the rework of that PR, and I ended up with some sort of conflict where the attribute was parsed then swallowed up by pycparser as that bit of the declaration is deemed irrelevant on that path, and is therefore dropped on the floor. I'm going to push the WIP commit I was working on, but that commit completely breaks the PR (it can just be reverted to get the simpler but incomplete fix that I originally submitted) |
776ed69
to
cde1128
Compare
Add support for GNU
__attribute__(())
in enum/struct/union definitions, both on the type itself and on enumerators.Fixes #42