Next Version 2.4.10 #2206
Merged
Next Version 2.4.10 #2206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I made the PR too early. The errors are related to the fact that the bundle is not already present: https://quay.io/repository/operatorhubio/infinispan?tab=tags&tag=v2.4.9 I re-run the CI as soon as we have it. |
ryanemerson
reviewed
Jan 14, 2025
test/e2e/utils/asserts.go
Outdated
| @@ -17,6 +17,7 @@ func LogError(err error) { | |||
| // ExpectNoError checks if an error exists, and if so halts execution | |||
| func ExpectNoError(err error) { | |||
| if err != nil { | |||
| LogError(err) | |||
There was a problem hiding this comment.
I think this is redundant as we already log the error in kubernetes.go#CleanNamespaceAndLogWithPanic after the panic is thrown.
There was a problem hiding this comment.
You're right. In fact, I have the same results. I'm removing it. Thanks
fax4ever
force-pushed
the
update-2.4.10
branch
from
276ba7f to
dd134a0
Compare
|
Thanks @fax4ever |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
draft => still need https://quay.io/repository/operatorhubio/infinispan?tab=tags&tag=v2.4.9done!