Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPROTO-343 Allow null values for primitive types with PROTO3 syntax #291

Merged
merged 1 commit into from
Jul 3, 2024
Merged

IPROTO-343 Allow null values for primitive types with PROTO3 syntax #291

merged 1 commit into from
Jul 3, 2024

Conversation

ryanemerson
Copy link
Contributor

@ryanemerson ryanemerson added this to the 5.0.6.Final milestone Jul 1, 2024
pruivo
pruivo requested changes Jul 1, 2024
View reviewed changes
Copy link
Member

@pruivo pruivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Primitive types aren't working anymore. I suggested a possible fix 🤞

...rg/infinispan/protostream/integrationtests/processor/marshaller/model/NullsAllowedModel.java Outdated Show resolved Hide resolved
core/src/main/java/org/infinispan/protostream/annotations/impl/ProtoMessageTypeMetadata.java Outdated Show resolved Hide resolved
@pruivo
Copy link
Member

pruivo commented Jul 1, 2024

ps. would be nice to add a primitive type into the test too 👍

@ryanemerson
Copy link
Contributor Author

Good spot @pruivo. Fix and test updates pushed.

@ryanemerson
Copy link
Contributor Author

@pruivo Should be good now. I updated the testsuite and @ProtoSchema docs to reflect that the null behaviour also applies to Enums and byte[].

@ryanemerson ryanemerson mentioned this pull request Jul 2, 2024
Merged
pruivo
pruivo approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@pruivo pruivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested with Keycloak (pruivo/keycloak@86a0614)

@pruivo pruivo merged commit d3498d0 into infinispan:main Jul 3, 2024
5 checks passed
@pruivo
Copy link
Member

pruivo commented Jul 3, 2024

merged! thanks @ryanemerson !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pruivo pruivo pruivo approved these changes

@tristantarrant tristantarrant Awaiting requested review from tristantarrant

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.6.Final
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanemerson @pruivo