Feature/reaction speed test measure #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAM-PARK
requested review from
gracefullight,
gaa0,
ckrbqja and
Lim-Ji-Hyeon
3 tasks
…patch 추가" This reverts commit 0fe1850.
- react-native-css-interop update 이후 jest failed - mocking 추가: test 에러 발생하는 useColorScheme
- react-native-svg: 14.1.0 - react-native-css-interop: ^0.0.36
- reaction-speed-test만 react-native-svg@14.1.0 버전 사용 중
JAM-PARK
force-pushed
the
feature/reaction-speed-test-measure
branch
from
4419cf2 to
8eec855
Compare
ckrbqja
approved these changes
Nov 19, 2024
- nativewind: 4.1.23 - react-native-css-interop: ^0.1.22 - react-native-svg: 14.1.0
gracefullight
approved these changes
Nov 23, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
설명 (Description)
react-native-svg를 사용하다 라이브러리 버전 문제가 생겨 올리는 PR입니다.관련 이슈 (Related Issues)
체크리스트 (Checklist)
리뷰 가이드라인 (Review Guidelines)
P1 (Priority 1): 반드시 바로 수정해야 할 항목입니다. 기능에 큰 영향을 주거나, 배포 전에 꼭 해결해야 하는 중요한 사항입니다.
P2 (Priority 2): 수정하면 코드가 더 개선될 수 있는 사항입니다. 큰 이슈는 아니지만, 수정하면 코드가 더 깔끔하고 유지보수가 쉬워집니다.
P3 (Priority 3): 당장 수정하지 않아도 괜찮지만, 나중에 개선하면 도움이 되는 사항입니다. 기본적으로 모든 리뷰는 P3로 간주해주시면 됩니다.