-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reaction-speed-test 기록 페이지 supabase 연동 #76
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lim-Ji-Hyeon
approved these changes
Jan 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오!! supabase를 이용해 기록한 데이터를 저장하고 UI에 표시하는 것까지 구현하셨네요!! 👍
ckrbqja
approved these changes
Jan 26, 2025
a758829
to
c76f7f4
Compare
gracefullight
approved these changes
Jan 27, 2025
f1f95d7
to
87f36d7
Compare
- main rebase 이후 로컬 앱 시작 시 env 에러 발생 Error: Error reading Expo config at /app-factory/apps/reaction-speed-test/app.config.ts: Required environment variable EXPO_PUBLIC_SUPABASE_URL is missing - 관련 커밋 a58d9e5 web-publish에서 env를 적용하기 위함
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
설명 (Description)
시작하기~insert
,기록보기~select
쿼리 적용관련 이슈 (Related Issues)
스크린샷/동영상 (Screenshots/Videos)
테스트 방법 (How to Test)
/apps/reaction-speed-test
에서pnpm run start
체크리스트 (Checklist)
리뷰 가이드라인 (Review Guidelines)
P1 (Priority 1): 반드시 바로 수정해야 할 항목입니다. 기능에 큰 영향을 주거나, 배포 전에 꼭 해결해야 하는 중요한 사항입니다.
P2 (Priority 2): 수정하면 코드가 더 개선될 수 있는 사항입니다. 큰 이슈는 아니지만, 수정하면 코드가 더 깔끔하고 유지보수가 쉬워집니다.
P3 (Priority 3): 당장 수정하지 않아도 괜찮지만, 나중에 개선하면 도움이 되는 사항입니다. 기본적으로 모든 리뷰는 P3로 간주해주시면 됩니다.