Feature/delivery #82
Open
Feature/delivery #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckrbqja
requested review from
gracefullight,
gaa0,
J0SEOYOUNG and
Lim-Ji-Hyeon
gracefullight
approved these changes
Feb 9, 2025
JAM-PARK
reviewed
Feb 9, 2025
| import { Button, ButtonSpinner, ButtonText } from "@/components/ui/button"; | ||
| import { Heading } from "@/components/ui/heading"; | ||
| import { VStack } from "@/components/ui/vstack"; | ||
| import useGlobalToast from "@/features/shared/hooks/useGlobalToast"; |
There was a problem hiding this comment.
useGlobalToast 훅이 궁금해서 찾아보니까
파일이 없는 것 같아요
커밋 누락일까요?
There was a problem hiding this comment.
아 ㅋㅋㅋ 맞아요 커밋 누락이네여
추가했습니다 감사합니다 ㅎㅎ
JAM-PARK
approved these changes
Feb 9, 2025
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
설명 (Description)
관련 이슈 (Related Issues)
#24
변경 내용 (Changes Made)
체크리스트 (Checklist)
리뷰 가이드라인 (Review Guidelines)
P1 (Priority 1): 반드시 바로 수정해야 할 항목입니다. 기능에 큰 영향을 주거나, 배포 전에 꼭 해결해야 하는 중요한 사항입니다.
P2 (Priority 2): 수정하면 코드가 더 개선될 수 있는 사항입니다. 큰 이슈는 아니지만, 수정하면 코드가 더 깔끔하고 유지보수가 쉬워집니다.
P3 (Priority 3): 당장 수정하지 않아도 괜찮지만, 나중에 개선하면 도움이 되는 사항입니다. 기본적으로 모든 리뷰는 P3로 간주해주시면 됩니다.