Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rotating mask #25

Closed
wants to merge 2 commits into from
Closed

feat: rotating mask #25

wants to merge 2 commits into from

Conversation

ink-victor
Copy link
Contributor

  • Configures the rotating mask on the demo nav icon
Screen.Recording.2024-11-21.at.15.29.33.mov

@ink-victor ink-victor requested a review from a team as a code owner November 21, 2024 20:31
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-25.d2yrqj5dnlvopf.amplifyapp.com

@fran-ink
Copy link
Contributor

Only works on the first instance of the icon since your SVG includes ids, which should be unique through the page.

I used to fix this by including a "GlobalSvgStuff" component that adds all those things that should be unique, but it seems very annoying for a library...

Not sure if we can generate a unique ID in the svg file...? 😓

@fran-ink
Copy link
Contributor

Also, your SVG file is invalid and it should stay valid.

If you want to wrap it in a div, I'd rather wrap it in a specific InkPlaceholderLogo component that adds the <div class="ink-group" thing

@ink-victor
Copy link
Contributor Author

Closing this PR as we're not sure the rotating mask will actually be part of the final designs. We can open the PR back up if we need.

@ink-victor ink-victor closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants