Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding configurable timeout for clients #259

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

soareswallace
Copy link
Contributor

Proposed changes

This PR introduces configurable timeout for the Incognia API. If no timeout is set, the library will continue to follow the OKHttp default that is 10 seconds.

Checklist

  • Style check and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@soareswallace soareswallace self-assigned this Feb 12, 2025
@soareswallace soareswallace requested a review from a team as a code owner February 12, 2025 19:05
@soareswallace soareswallace marked this pull request as draft February 12, 2025 19:05
@soareswallace soareswallace marked this pull request as ready for review February 12, 2025 19:12
@soareswallace soareswallace force-pushed the add-configurable-timeout-for-java-lib branch 2 times, most recently from d754f61 to 1f069fd Compare February 13, 2025 12:54
@brunoekferrari brunoekferrari self-requested a review February 13, 2025 13:00
@soareswallace soareswallace force-pushed the add-configurable-timeout-for-java-lib branch 3 times, most recently from cb962d5 to 1c7b895 Compare February 13, 2025 14:01
Copy link
Contributor

@brunoekferrari brunoekferrari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and approved.

@soareswallace soareswallace force-pushed the add-configurable-timeout-for-java-lib branch 4 times, most recently from 18daa51 to 4378a80 Compare February 13, 2025 14:54
@soareswallace soareswallace force-pushed the add-configurable-timeout-for-java-lib branch from 4378a80 to e82216e Compare February 13, 2025 16:47
@soareswallace soareswallace force-pushed the add-configurable-timeout-for-java-lib branch from e82216e to 651b39e Compare February 13, 2025 19:06
@soareswallace soareswallace force-pushed the add-configurable-timeout-for-java-lib branch from 651b39e to 7c0d2d0 Compare February 14, 2025 17:42
@soareswallace soareswallace force-pushed the add-configurable-timeout-for-java-lib branch from 7c0d2d0 to b9ef23d Compare February 14, 2025 17:43
@soareswallace soareswallace force-pushed the add-configurable-timeout-for-java-lib branch from b9ef23d to 708a424 Compare February 14, 2025 17:47
@soareswallace soareswallace merged commit c0e4465 into master Feb 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants