-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding configurable timeout for clients #259
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d754f61
to
1f069fd
Compare
cb962d5
to
1c7b895
Compare
brunoekferrari
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and approved.
18daa51
to
4378a80
Compare
racevedoo
reviewed
Feb 13, 2025
gaabs
reviewed
Feb 13, 2025
gaabs
reviewed
Feb 13, 2025
4378a80
to
e82216e
Compare
racevedoo
reviewed
Feb 13, 2025
e82216e
to
651b39e
Compare
racevedoo
reviewed
Feb 14, 2025
racevedoo
approved these changes
Feb 14, 2025
gaabs
approved these changes
Feb 14, 2025
651b39e
to
7c0d2d0
Compare
7c0d2d0
to
b9ef23d
Compare
b9ef23d
to
708a424
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR introduces configurable timeout for the Incognia API. If no timeout is set, the library will continue to follow the OKHttp default that is 10 seconds.
Checklist