Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add project fields validator #334

Merged
merged 51 commits into from
Feb 6, 2025

Conversation

minikin
Copy link
Collaborator

@minikin minikin commented Oct 18, 2024

Description

  • auto assign PR creator as assignee
  • verifies that all project fields are filled out and fail if any are left unfilled.

resolves #333

@minikin minikin self-assigned this Oct 18, 2024
@minikin minikin added do not merge yet PR is not ready to be merged yet do not review yet Do not review yet labels Oct 18, 2024
@minikin minikin assigned minikin and unassigned minikin Oct 22, 2024
@minikin minikin assigned minikin and unassigned minikin Oct 22, 2024
Mr-Leshiy
Mr-Leshiy previously approved these changes Oct 23, 2024
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minikin minikin added review me PR is ready for review and removed do not review yet Do not review yet labels Oct 27, 2024
@minikin
Copy link
Collaborator Author

minikin commented Oct 27, 2024

@stevenj, can you please review? Let me know if we should create a better code structure for Python.
PS: The validate-project-fields job is failing because the GitHub token used in CI doesn't have sufficient permissions to access the project.

@github-actions github-actions bot deleted the feat/validate-project-fields-in-prs-and-issues branch December 20, 2024 06:08
@minikin minikin restored the feat/validate-project-fields-in-prs-and-issues branch January 8, 2025 11:29
@minikin minikin changed the title ci: add project fields validator ci: Add project fields validator Jan 8, 2025
minikin and others added 4 commits January 30, 2025 14:59
* feat(cat-ci): Make the action only use python standard libraries so its easier to use outside earthly

* feat(python): Add feature to check stand alone python files (no 3rd party imports, no poetry)

* feat(python): make check use stand alone python mode

* feat(python): add local coce formater and linter check for python

* feat(python): more edits for stand alone mode and debugging

* fix(python): third parry imports check needs rust

* fix(python): fix ci issues with changes made

* fix(python): Fix CI issues found with the improved python tooling

* fix(cat-ci): remove debug prints

* fix(cat-ci): project action runner

* fix(cat-ci): try action again

* fix(cat-ci): Try and actually run the action now

* fix(cat-ci): try a custom PAT secret

* fix(cat-ci): Update token scope doc

* fix(cat-ci): Rename GITHUB_TOKEN to make it distinct from other tokens

* fix(cat-ci): secrets can't start with GITHUB_
@stevenj
Copy link
Collaborator

stevenj commented Feb 5, 2025

Will need to change the branch in the action to master so it can fetch the right code after the merge.

@minikin minikin removed the do not merge yet PR is not ready to be merged yet label Feb 6, 2025
@minikin minikin merged commit 1bd97b8 into master Feb 6, 2025
29 of 30 checks passed
@minikin minikin deleted the feat/validate-project-fields-in-prs-and-issues branch February 6, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Make github action/s which can pre populate and validate Project fields in PRs and Issues
4 participants