ui: remove enzyme from common #3509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DonHaul
commented
Mar 18, 2025
DonHaul
commented
- ref: ui: remove enzyme from common cern-sis/issues-inspire#775
DonHaul
force-pushed
the
enzyme-is-dead-common-2
branch
2 times, most recently
from
413bdab to
f9b67fb
Compare
inspirehep
|
||||||||||||||||||||||||||||
| Project |
inspirehep
|
| Branch Review |
enzyme-is-dead-common-2
|
| Run status |
|
| Run duration | 07m 45s |
| Commit |
|
| Committer | DonHaul |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
37
|
Skipped
|
0
|
Passing
|
67
|
| View all changes introduced in this branch ↗︎ | |
ioannistsanaktsidis
requested changes
Mar 19, 2025
| const wrapper = shallow(<UnlinkedAuthor author={author} />); | ||
| expect(wrapper).toMatchSnapshot(); | ||
| const { getByText } = render(<UnlinkedAuthor author={author} />); | ||
| getByText('Name, Full'); |
There was a problem hiding this comment.
here you are missing the expect part
| expect(wrapper.find(GoBackLink)).toHaveProp({ | ||
| children: 'custom', | ||
| }); | ||
| expect(getByRole('button')); |
There was a problem hiding this comment.
here you are also missing the .somthing after the expect
DonHaul
force-pushed
the
enzyme-is-dead-common-2
branch
from
f9b67fb to
fe7ceca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.