Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitoring: error messages for disambiguation #3517

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

DonHaul
Copy link
Contributor

@DonHaul DonHaul commented Mar 20, 2025

Copy link

cypress bot commented Mar 20, 2025

inspirehep    Run #34524

Run Properties:  status check passed Passed #34524  •  git commit df1c9a8c2a: monitoring: error messages for disambiguation
Project inspirehep
Branch Review disambiguation-logging2
Run status status check passed Passed #34524
Run duration 07m 23s
Commit git commit df1c9a8c2a: monitoring: error messages for disambiguation
Committer DonHaul
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 37
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 67
View all changes introduced in this branch ↗︎

Copy link
Collaborator

@ioannistsanaktsidis ioannistsanaktsidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

@DonHaul DonHaul force-pushed the disambiguation-logging2 branch from 71d0350 to 246b5c2 Compare March 20, 2025 13:46
Copy link
Collaborator

@ioannistsanaktsidis ioannistsanaktsidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor change and we are good!

@DonHaul DonHaul force-pushed the disambiguation-logging2 branch 3 times, most recently from ba9ded4 to 7d7a754 Compare March 21, 2025 09:57
@DonHaul DonHaul force-pushed the disambiguation-logging2 branch from 7d7a754 to df1c9a8 Compare March 21, 2025 10:33
Copy link
Collaborator

@ioannistsanaktsidis ioannistsanaktsidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@DonHaul DonHaul merged commit ecf595a into inspirehep:master Mar 21, 2025
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants