-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new spacing tokens + spacing docs + margin props for input components #1812
base: master
Are you sure you want to change the base?
Conversation
|
3ea6398
to
82f42a7
Compare
82f42a7
to
ac2ee2d
Compare
Nice work, I like it so far :) It would be good to have a visual test for all these margins. I suggest to make a large single test (like with |
584d176
to
7684341
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm when the already mentioned issues are fixed.
Nice work!
7684341
to
2332fd6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except that the Margin prop
stories are not in Storybook, I think you need to add them to stories.ts
Also can you check the Storybook stories and accept them if they look good?
2332fd6
to
581f246
Compare
581f246
to
34424ca
Compare
INSTUI-4387
INSTUI-4367
test plan: