docs(ui-radio-input,ui-source-code-editor): add functional examples t… #1842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o SourceCodeEditor and class-based examples to RadioInputGroup Closes: INSTUI-4419
|
balzss
requested changes
Feb 3, 2025
| ``` | ||
|
|
||
| - ```js | ||
| const languages = { |
There was a problem hiding this comment.
the source code has extra padding in the functional examples
| const handleChange = function (event, value) { | ||
| console.log(value) | ||
| - ```js | ||
| class Example extends React.Component { |
There was a problem hiding this comment.
in the (far away) future we will probably only need functional examples for components so I'd suggest not to add class based ones if we don't have them already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o SourceCodeEditor and class-based examples to RadioInputGroup
Closes: INSTUI-4419
TEST PLAN:
- test all the class-based examples in RadioInputGroup if they work the same as the functional examples and without error
- test all the functional examples in SourceCodeEditor if they work the same as the class-based and without error