(WIP) Fix description text not read on hover by NVDA #1863
+119
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not read on hover with NVDA use a span with ARIA tags instead of fieldset INSTUI-4444
|
matyasf
commented
Feb 6, 2025
| ref={this.handleRef} | ||
| > | ||
| {this.elementType === 'fieldset' && this.renderLegend()} |
There was a problem hiding this comment.
The old solution used here a fieldset element. SR only reads its <legend> if its the first element. But we use a Grid, so the old solution was to add a <legend> as ScreenReaderContent and use aria-hidden on the visible label.
The new solution uses aria-labelledby instead, so there is just one, visible DOM element for the label
matyasf
commented
Feb 7, 2025
| @@ -148,6 +148,7 @@ class CheckboxGroup extends Component<CheckboxGroupProps, CheckboxGroupState> { | |||
| vAlign="top" | |||
| messagesId={this._messagesId} | |||
| elementRef={this.handleRef} | |||
| role="group" | |||
There was a problem hiding this comment.
This makes SRs read the same as the fieldset previously
matyasf
changed the title
matyasf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that NVDA hover mode was not reading form labels because they were set to
aria-hidden.This solution uses
aria-labelledbyinstead, see e.g. https://dequeuniversity.com/library/aria/radio-and-radio-group . Also it no longer reads messages in the beginning, this was not neededTo test:
Check the examples of CheckboxGroup, FormField, RadioInputGroup with NVDA, JAWS, VoiceOver.
NVDA should read the label on hover. Form groups should be announced
There should be no visual change.
Closes: INSTUI-4444