-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(e2e): add tests for budget edit #864
Conversation
Extension builds preview
|
Figuring out why worker gets reused here.. It's supposed to disconnect wallet after each file finishes running. |
Sad here. |
It doesn't call disconnectWallet at end of each test file (we need afterAll for that) - it is called only once per worker.
So, |
reduce test flakiness
This reverts commit abd0b3a.
So...
There's no way to run a hook before all tests in a file. A worker will share state across files. 🤦🏽 Filed microsoft/playwright#34519 to see if can get some hint there. |
Closing this as it got too noisy with attempts on fixing flakiness. Will send fresh PR. |
Context
Part of #610
Changes proposed in this pull request