Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Jobs Not Being Updated To Complete After Completing Test #387

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Fix Jobs Not Being Updated To Complete After Completing Test #387

wants to merge 9 commits into from

Conversation

Zakaria-Kofiro
Copy link
Collaborator

title: -

Please make sure these check boxes are checked before submitting

  • ** Squashed Commits **
  • ** All Tests Passed ** - mvn clean test -P default

** PR review process **

  • Requires one +1 from a reviewer
  • Repository owners will merge your PR once it is approved.

@Zakaria-Kofiro Zakaria-Kofiro marked this pull request as ready for review March 20, 2025 19:28
kevin-mcgoldrick
kevin-mcgoldrick reviewed Mar 20, 2025
View reviewed changes
Copy link
Collaborator

@kevin-mcgoldrick kevin-mcgoldrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Why the new variable sendFinalUpdate. It appears to always have the same value as doMonitor
  • Please no, adding INFO logs. Can you make them DEBUG?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-mcgoldrick kevin-mcgoldrick kevin-mcgoldrick left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zakaria-Kofiro @kevin-mcgoldrick