Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix get-positions and allow none on empty single withdraw #78

Merged
merged 4 commits into from
Sep 16, 2024
Merged

fix get-positions and allow none on empty single withdraw #78

merged 4 commits into from
Sep 16, 2024

Conversation

none00y
Copy link
Contributor

@none00y none00y commented Sep 13, 2024

Changes

  • changed single withdraw to not panic if None is passed and the balance doesn't exit
  • changed getPositions to retain position order

@none00y none00y self-assigned this Sep 13, 2024
@none00y none00y marked this pull request as ready for review September 13, 2024 17:21
@none00y none00y merged commit 5667528 into master Sep 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojciech-cichocki wojciech-cichocki wojciech-cichocki approved these changes

Assignees

@none00y none00y

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@none00y @wojciech-cichocki