-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customize: Nest static page admin panel under v12 #600
Conversation
Now we can go to our custom page again and see the content displayed on the page. | ||
|
||
 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I relocated this section to the bottom because, if I'm not mistaken, the following section pertains to v11 to avoid flipping versions back and forth.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the full "Edit pages" section is v12 specific right? We can move it all below and tag it as such. This way the heading is for the functionality (more navigable). We could also point out in the intro paragraph of this page that this is the case:
InvenioRDM supports an easy "out-of-the-box" way of creating static pages, basically web pages for which the HTML content is stored in the database.
And you can change them using the administration panel in v12.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small further placement I think, but otherwise straightforward, thanks!
Now we can go to our custom page again and see the content displayed on the page. | ||
|
||
 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the full "Edit pages" section is v12 specific right? We can move it all below and tag it as such. This way the heading is for the functionality (more navigable). We could also point out in the intro paragraph of this page that this is the case:
InvenioRDM supports an easy "out-of-the-box" way of creating static pages, basically web pages for which the HTML content is stored in the database.
And you can change them using the administration panel in v12.
bf26087
to
0f9447a
Compare
@fenekku I hope I've understood you correctly. As |
Your changes are right on what I meant. Merging, thank you! |
❤️ Thank you for your contribution!
Description
Place the admin panel under v12, as its current positioning misleadingly suggests that v11 includes this feature.
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Third-party code
If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: