Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize: Nest static page admin panel under v12 #600

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

Samk13
Copy link
Member

@Samk13 Samk13 commented Feb 14, 2024

❤️ Thank you for your contribution!

Description

Place the admin panel under v12, as its current positioning misleadingly suggests that v11 includes this feature.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@Samk13 Samk13 requested a review from fenekku February 14, 2024 15:35
Now we can go to our custom page again and see the content displayed on the page.

![Custom page with content](./img/custom-page_with-content.png)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I relocated this section to the bottom because, if I'm not mistaken, the following section pertains to v11 to avoid flipping versions back and forth.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the full "Edit pages" section is v12 specific right? We can move it all below and tag it as such. This way the heading is for the functionality (more navigable). We could also point out in the intro paragraph of this page that this is the case:

InvenioRDM supports an easy "out-of-the-box" way of creating static pages, basically web pages for which the HTML content is stored in the database.
And you can change them using the administration panel in v12.

Copy link
Collaborator

@fenekku fenekku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small further placement I think, but otherwise straightforward, thanks!

Now we can go to our custom page again and see the content displayed on the page.

![Custom page with content](./img/custom-page_with-content.png)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the full "Edit pages" section is v12 specific right? We can move it all below and tag it as such. This way the heading is for the functionality (more navigable). We could also point out in the intro paragraph of this page that this is the case:

InvenioRDM supports an easy "out-of-the-box" way of creating static pages, basically web pages for which the HTML content is stored in the database.
And you can change them using the administration panel in v12.

@Samk13
Copy link
Member Author

Samk13 commented Feb 14, 2024

@fenekku I hope I've understood you correctly. As Changing the base template section I'm not 100 if it pertains to V11 or 12.
If there's anything else that requires adjustments, please let me know or feel free to edit it yourself, your hands are free here :)

@fenekku
Copy link
Collaborator

fenekku commented Feb 15, 2024

@fenekku I hope I've understood you correctly. As Changing the base template section I'm not 100 if it pertains to V11 or 12. If there's anything else that requires adjustments, please let me know or feel free to edit it yourself, your hands are free here :)

Your changes are right on what I meant. Merging, thank you!

@fenekku fenekku merged commit 9eb4523 into inveniosoftware:master Feb 15, 2024
1 check passed
@Samk13 Samk13 deleted the static-page-fix branch February 15, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants