Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customization: instructions for changing menus #615

Conversation

martinobersteiner
Copy link

❤️ Thank you for your contribution!

Description

Adds instructions for customizing menus.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@kpsherva kpsherva changed the base branch from master to dev April 10, 2024 09:08
@martinobersteiner martinobersteiner force-pushed the feature/menu-customization branch from 1fb9a27 to 1c495bf Compare April 10, 2024 10:38
@martinobersteiner martinobersteiner force-pushed the feature/menu-customization branch from 1c495bf to 45874f1 Compare April 24, 2024 13:25
@martinobersteiner martinobersteiner force-pushed the feature/menu-customization branch from 45874f1 to 85c42c8 Compare June 11, 2024 11:23
Samk13 and others added 5 commits June 16, 2024 22:24
* Feat: Set up dark mode 🌙

* Implement dark mode
* Remove outdated overrides

* Remove redundant overrides.
* Seems like these overrides has no effect with the new version see https://squidfunk.github.io/mkdocs-material/upgrade/#changes-to-html-files_1

* frontpage: remove hard coded values in wave-svg

* footer:  remove Made with Material for MkDocs

* css: adapt custom css to the dark mode

* css: cleanup duplicates

* Automatic light / dark mode

* css: clean up

* update btn colors
* remove duplicates

* css colors: replace hard coded values with vars and cleanup duplicates

* footer: bring back made with MKDocs

* home: fix toggle not showing on frontpage and features

* Remove frontpage_base.html override as we are extending from main
* Still need to fix gradient color cut and style diffrence between dark and light mode

* fix line showing on screen resize

* Update CSS styles to fix gradiant without affecting other pages

* Fix homepage gradients without the need to override base.html

* fix size change on theme toggle

* css: show Github stars and forks

* fix transform value

* css: cleanup rules and refactor duplicates

* Update CSS styles to isolate changes to specific pages

* fix console warnings

* remove 'Home' on frontpage + adjust indentation

---------

Co-authored-by: Guillaume Viger <fenekku@fenekku.com>
* based on IP ranges, in `nginx`
Also fix the case from "ORCiD" to "ORCID".
@utnapischtim utnapischtim requested a review from max-moser July 9, 2024 19:26
Samk13 added 4 commits July 9, 2024 21:39
Changed `expires_at` from ISO 8601 DateTime to Date format to fix validation error.
Removed created_by.user, receiver.community, and topic.record due to Unknown field validation errors.
…r expires_at

- update response examples for access links
@utnapischtim utnapischtim requested a review from fenekku July 9, 2024 19:49
@fenekku fenekku self-assigned this Jul 10, 2024
@fenekku fenekku force-pushed the feature/menu-customization branch from 85c42c8 to 50a45aa Compare July 10, 2024 13:45
@fenekku fenekku force-pushed the feature/menu-customization branch from 50a45aa to f4738cd Compare July 10, 2024 13:52
@fenekku
Copy link
Collaborator

fenekku commented Jul 10, 2024

Thank you for the docs about menu customization and sorry for the wait @martinobersteiner !

I've changed the PR's target to the master branch and took the liberty of enhancing the docs a little bit (mention "tabs", capitalize some things, reword some). You will find the new one here: #679

In any case, we will probably revisit this kind of documentation in the future as it provides very useful information across multiple dimensions that we may want to tease apart: it's laying out a reference in a how-to.

I also didn't have time to make glitchbox work so that the screenshots can be clicked on to be better seen. Made a separate ticket for that: #680 .

Closing this one and referring to that other one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants