Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vocabularies: names: link to datasets for all years #677

Merged

Conversation

ptamarit
Copy link
Member

@ptamarit ptamarit commented Jul 9, 2024

Also fix the case from "ORCiD" to "ORCID".

❤️ Thank you for your contribution!

Description

The current link points to the ORCID dataset from 2021. The proposal is to change the link to some ORCID documentation which contains the list of the datasets of all years.

I also changed the case from "ORCiD" to "ORCID" since I did not find any official places using this mixed casing.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

Also fix the case from "ORCiD" to "ORCID".
@ptamarit ptamarit self-assigned this Jul 9, 2024
@ptamarit ptamarit requested a review from jrcastro2 July 9, 2024 13:18
Copy link
Collaborator

@fenekku fenekku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think this is v12 related and I am ruthlessly getting those in.

@fenekku fenekku merged commit 296df87 into inveniosoftware:master Jul 9, 2024
1 check passed
@ptamarit ptamarit deleted the orcid-public-dataset-link-latest branch July 9, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants