ui: add mathjax to record details page #2538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpsherva
reviewed
Nov 16, 2023
invenio_app_rdm/config.py
Outdated
| @@ -234,6 +234,11 @@ def _(x): | |||
|
|
|||
| THEME_JAVASCRIPT_TEMPLATE = "invenio_app_rdm/javascript.html" | |||
|
|
|||
| THEME_MATHJAX_CDN = ( | |||
There was a problem hiding this comment.
was it agreed on to use the cdn in the invenioRDM core? should we use it only in zenodo? to be discussed.
There was a problem hiding this comment.
Agree, by default this should be disabled. But I would keep the "automatic" addition in the javascript block if the config is set.
slint
reviewed
Nov 16, 2023
| @@ -360,6 +360,7 @@ <h4>{{ _("Request access") }}</h4> | |||
| {%- endblock page_body %} | |||
|
|
|||
| {%- block javascript %} | |||
| <script type="text/javascript" src="{{ config.THEME_MATHJAX_CDN }}"></script> | |||
There was a problem hiding this comment.
Suggested change
| <script type="text/javascript" src="{{ config.THEME_MATHJAX_CDN }}"></script> | |
| {% if config.THEME_MATHJAX_CDN %} | |
| <script type="text/javascript" src="{{ config.THEME_MATHJAX_CDN }}"></script> | |
| {% endif %} |
As suggested above.
There was a problem hiding this comment.
Now that I think about it, shouldn't this bee already defined like this in invenio-theme? Where did the THEME_ prefix come from?
There was a problem hiding this comment.
There's no mathjax defined in invenio-theme. Took this constant name from the legacy https://github.com/zenodo/zenodo/blob/master/zenodo/config.py#L1427
anikachurilova
force-pushed
the
add-mathjax
branch
from
b941833 to
ff4bc0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Landing page:
Request page:
