fix(ios): banners not properly destroyed

invertase · Dec 27, 2023 · cef8f9e · cef8f9e
1 parent bfec491
commit cef8f9e
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/ios/RNGoogleMobileAds/RNGoogleMobileAdsBannerComponent.m b/ios/RNGoogleMobileAds/RNGoogleMobileAdsBannerComponent.m
@@ -23,6 +23,15 @@
 
 @implementation RNGoogleMobileAdsBannerComponent
 
+- (void)removeFromSuperview {
+  if (_banner) {
+    [_banner removeFromSuperview];
+    _banner = nil;
+  }
+
+  [super removeFromSuperview];
+}
+
 - (void)didSetProps:(NSArray<NSString *> *)changedProps {
   if (_propsChanged) {
     [self requestAd];

diff --git a/ios/RNGoogleMobileAds/RNGoogleMobileAdsBannerView.mm b/ios/RNGoogleMobileAds/RNGoogleMobileAdsBannerView.mm
@@ -94,6 +94,13 @@ - (void)updateProps:(Props::Shared const &)props oldProps:(Props::Shared const &
   [super updateProps:props oldProps:oldProps];
 }
 
+- (void)dealloc {
+  if (_banner) {
+    [_banner removeFromSuperview];
+    _banner = nil;
+  }
+}
+
 #pragma mark - Methods
 
 - (void)initBanner:(GADAdSize)adSize {