Enable TLS Server Name Indication #186
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Cernekee <cernekee@chromium.org>
In environments where SSL interception is in place, the SNI field is often used to figure out whether to enable or disable interception for a new connection. Enable SNI on tlsdate requests. More background info: http://crbug.com/400429 Signed-off-by: Kevin Cernekee <cernekee@chromium.org>
|
@ioerror gentle ping |
|
I'll look into merging this in the next few weeks. If anyone wants to
provide a detailed review, it will speed things up, of course.
|
akiernan
pushed a commit
to akiernan/tlsdate
that referenced
this pull request
Jan 11, 2019
Upstream submission: ioerror#186 In environments where SSL interception is in place, the SNI field is often used to figure out whether to enable or disable interception for a new connection. Enable SNI on tlsdate requests. BUG=chromium:400429 TEST=sniff tlsdate's ClientHello message before/after the change, and verify that it contains "clients3.google.com" under "Extension: server_name" Change-Id: Ibe6383bd0b9b590a16a08ae8e1b74ee0f401b3f0 Signed-off-by: Kevin Cernekee <cernekee@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/339834 Reviewed-by: Thiemo Nagel <tnagel@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org>
akiernan
pushed a commit
to akiernan/tlsdate
that referenced
this pull request
Jan 16, 2019
Upstream submission: ioerror#186 In environments where SSL interception is in place, the SNI field is often used to figure out whether to enable or disable interception for a new connection. Enable SNI on tlsdate requests. BUG=chromium:400429 TEST=sniff tlsdate's ClientHello message before/after the change, and verify that it contains "clients3.google.com" under "Extension: server_name" Change-Id: Ibe6383bd0b9b590a16a08ae8e1b74ee0f401b3f0 Signed-off-by: Kevin Cernekee <cernekee@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/339834 Reviewed-by: Thiemo Nagel <tnagel@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org>
akiernan
pushed a commit
to akiernan/tlsdate
that referenced
this pull request
Jan 16, 2019
Upstream submission: ioerror#186 In environments where SSL interception is in place, the SNI field is often used to figure out whether to enable or disable interception for a new connection. Enable SNI on tlsdate requests. BUG=chromium:400429 TEST=sniff tlsdate's ClientHello message before/after the change, and verify that it contains "clients3.google.com" under "Extension: server_name" Change-Id: Ibe6383bd0b9b590a16a08ae8e1b74ee0f401b3f0 Signed-off-by: Kevin Cernekee <cernekee@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/339834 Reviewed-by: Thiemo Nagel <tnagel@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org>
akiernan
pushed a commit
to akiernan/tlsdate
that referenced
this pull request
Jan 16, 2019
Upstream submission: ioerror#186 In environments where SSL interception is in place, the SNI field is often used to figure out whether to enable or disable interception for a new connection. Enable SNI on tlsdate requests. BUG=chromium:400429 TEST=sniff tlsdate's ClientHello message before/after the change, and verify that it contains "clients3.google.com" under "Extension: server_name" Change-Id: Ibe6383bd0b9b590a16a08ae8e1b74ee0f401b3f0 Signed-off-by: Kevin Cernekee <cernekee@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/339834 Reviewed-by: Thiemo Nagel <tnagel@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org>
akiernan
pushed a commit
to akiernan/tlsdate
that referenced
this pull request
Jan 16, 2019
Upstream submission: ioerror#186 In environments where SSL interception is in place, the SNI field is often used to figure out whether to enable or disable interception for a new connection. Enable SNI on tlsdate requests. BUG=chromium:400429 TEST=sniff tlsdate's ClientHello message before/after the change, and verify that it contains "clients3.google.com" under "Extension: server_name" Change-Id: Ibe6383bd0b9b590a16a08ae8e1b74ee0f401b3f0 Signed-off-by: Kevin Cernekee <cernekee@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/339834 Reviewed-by: Thiemo Nagel <tnagel@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org>
akiernan
pushed a commit
to akiernan/tlsdate
that referenced
this pull request
Feb 26, 2019
Upstream submission: ioerror#186 In environments where SSL interception is in place, the SNI field is often used to figure out whether to enable or disable interception for a new connection. Enable SNI on tlsdate requests. BUG=chromium:400429 TEST=sniff tlsdate's ClientHello message before/after the change, and verify that it contains "clients3.google.com" under "Extension: server_name" Change-Id: Ibe6383bd0b9b590a16a08ae8e1b74ee0f401b3f0 Signed-off-by: Kevin Cernekee <cernekee@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/339834 Reviewed-by: Thiemo Nagel <tnagel@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables TLS SNI. See also: bug #161 and crbug.com/400429