Update ioos-qc package #427
Open
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated to the new release: v2.2.0
|
Can you check the type hints in the unit tests? |
ocefpaf
reviewed
Feb 28, 2025
| @@ -26,8 +26,7 @@ thredds_crawler>=1.5.4 | |||
| pyyaml>=5.2 | |||
| rq==1.3.0 | |||
| rq-dashboard==0.3.4 | |||
| # pin IOOS QC to a particular commit on main until stable version with fixes is released | |||
| -e git+https://github.com/ioos/ioos_qc@57813de111af201f8d7b68c7fcd6337bf37dd6ed#egg=ioos_qc | |||
| git+https://github.com/ioos/ioos_qc.git@v2.2.0#egg=ioos_qc | |||
There was a problem hiding this comment.
Can we use the stable version from PyPI or conda instead of the GitHub release? GH releases are, sadly, not immutable and if by mistake someone edits that, it may cause some really hard to debug breakages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to the new release: v2.2.0