Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "kinesis" wording and switch back to "iota" #1433

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

wulfraem
Copy link
Contributor

@wulfraem wulfraem commented Nov 21, 2024

Description of change

During development, the placeholder name "kinesis" was used for IOTA rebased in this project. This PR removes this placeholder name and lets the "iota" based naming take over the role of the "kinesis" based naming.

This is most evident in the feature names, e.g.:

  • feature kinesis-client -> iota-client
  • feature kinesis -> iota

Therefore, the "iota" based names should be responsible for the same things in the rebased code base as they were in the stardust implementation.

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Tested against local tests.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@wulfraem wulfraem added Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. labels Nov 21, 2024
@wulfraem wulfraem changed the title remove "kinesis" and switch back to "iota" Remove "kinesis" wording and switch back to "iota" Nov 21, 2024
@wulfraem wulfraem force-pushed the feat/remove-stardust-related-code branch from ba2a99a to 8006769 Compare November 25, 2024 11:04
@wulfraem wulfraem changed the base branch from feat/remove-stardust-related-code to feat/identity-rebased-alpha November 25, 2024 15:38
@wulfraem wulfraem changed the base branch from feat/identity-rebased-alpha to feat/identity-rebased November 25, 2024 15:40
@wulfraem wulfraem changed the base branch from feat/identity-rebased to feat/identity-rebased-alpha November 25, 2024 16:05
@wulfraem wulfraem force-pushed the feat/remove-kinesis-wording branch from 0b367e0 to 2704f43 Compare November 25, 2024 16:07
@wulfraem wulfraem marked this pull request as ready for review November 25, 2024 16:08
@wulfraem wulfraem requested a review from a team as a code owner November 25, 2024 16:08
@wulfraem wulfraem merged commit ca30f9b into feat/identity-rebased-alpha Nov 26, 2024
2 checks passed
@wulfraem wulfraem deleted the feat/remove-kinesis-wording branch March 5, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants